Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syntax highlighting to better support terraform 0.12 #181

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@MattFenner
Copy link
Contributor

commented Jun 1, 2019

For #157 (but doesn't close it)

I have had a go at improving the syntax highlighting for Terraform 0.12 and beyond. I probably haven't fixed every case, but this should make it better especially for type definitions, expressions and function calls.

NOTE: this will not fix the erroneous syntax errors, but it will at least make the coloring better.

Also NOTE: this is my first time ever contributing to the project or any open source project, so please review closely, and let me know if I have done anything wrong.

@MattFenner

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2019

The build failed. But as far as I can see all builds have been failing for a while. Doesn't seem to be anything to do with my commit.

@mauve

This comment has been minimized.

Copy link
Owner

commented Jun 1, 2019

@syntaqx

This comment has been minimized.

Copy link

commented Jun 5, 2019

Hope to see this get merged in soon. It hurts so bad 😭

@mauve mauve merged commit 4eb3d4c into mauve:master Jun 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@mauve

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2019

Thanks for your contribution and thanks for your patience

@MattFenner MattFenner deleted the MattFenner:syntax-update-0-12 branch Jun 6, 2019

@davisford

This comment has been minimized.

Copy link

commented Jun 11, 2019

@mauve can you possibly do an incremental release with the new changes so we can try it out, or maybe put a build out on github that we can grab and install manually?

@thebigredgeek

This comment has been minimized.

Copy link

commented Jun 13, 2019

Can we please cut a release on this? Happy to pay a $25 USD bounty to make it happen

@mauve

This comment has been minimized.

Copy link
Owner

commented Jun 13, 2019

released as part of 1.3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.