Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up PR for UTM_GLOBAL_POSITION #1023

Merged
merged 4 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@eyeam3
Copy link
Contributor

commented Nov 15, 2018

There have been requested changes open from #1009. This is the follow up PR to address them as well.

  • Add centisecond as unit to update_rate field
  • Add missing display tag

Related to ArduPilot/pymavlink#242

@eyeam3 eyeam3 force-pushed the Auterion:feature/UTM_follow_up branch from 771e25b to bfc24bf Nov 15, 2018

@eyeam3

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

The test fails because cs is not defined in pymavlink. This was added ArduPilot/pymavlink#242 just recently.

@hamishwillee

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2018

@eyeam3 Thanks for being so fast. There doesn't seem to be a process for automatically updating the submodule dependency. I've created a PR for this (see link above).

@hamishwillee hamishwillee referenced this pull request Jan 2, 2019

Merged

Pymavlink update #1045

@hamishwillee

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

@eyeam3 I've pulled in latest Pymavlink and tests now pass - so this can be approved. Can you confirm nothing else needs to change/that this can be merged?

@eyeam3

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

Should be good to go. These were the open requests from the previous PR and the discussion around it.

@hamishwillee

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

Merging as this has previously been reviewed/approved, it is a WIP message, and it builds without error.

@hamishwillee hamishwillee merged commit 2211bf3 into mavlink:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.