Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mount mode with MAV_CMD_DO_MOUNT_CONFIGURE #1319

Merged
merged 4 commits into from Sep 26, 2019

Conversation

@Jaeyoung-Lim
Copy link
Contributor

@Jaeyoung-Lim Jaeyoung-Lim commented Sep 25, 2019

This PR is a follow up of #1257 where it adds a service to configure the MOUNT_MODE for the mount_control plugin

mavros_msgs/srv/MountConfigure.srv Outdated Show resolved Hide resolved
vooon
vooon approved these changes Sep 25, 2019
Copy link
Member

@vooon vooon left a comment

Looks good.

mavros_msgs/srv/MountConfigure.srv Outdated Show resolved Hide resolved
mavros_msgs/srv/MountConfigure.srv Outdated Show resolved Hide resolved
@Jaeyoung-Lim
Copy link
Contributor Author

@Jaeyoung-Lim Jaeyoung-Lim commented Sep 26, 2019

@vooon @TSC21 Thanks for the comments! I have applied the feedback in the last commit

@Jaeyoung-Lim
Copy link
Contributor Author

@Jaeyoung-Lim Jaeyoung-Lim commented Sep 26, 2019

This will also have conflicts with #1297

vooon
vooon approved these changes Sep 26, 2019
Copy link
Member

@vooon vooon left a comment

LGTM

@vooon vooon merged commit f99c8b2 into mavlink:master Sep 26, 2019
1 of 2 checks passed
@Jaeyoung-Lim Jaeyoung-Lim deleted the pr-mountcontrol-configure branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants