Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more and more deprecated issues #8758

Merged

Conversation

patrickelectric
Copy link
Member

No description provided.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric patrickelectric changed the title Fix more and more deprecated Fix more and more deprecated issues May 18, 2020
@patrickelectric
Copy link
Member Author

@DonLakeFlyer this fix a bunch of warning problems related to the deprecated functions.
We are also unable to build QGC anymore, since warnings appears to be errors now, so anyone that is using a modern Qt version is unable to build QGC right now.

@jaxxzer
Copy link
Collaborator

jaxxzer commented May 18, 2020

asprintf was introduced in Qt 5.5 https://doc.qt.io/qt-5/qstring.html#asprintf. There is a warning in the doc:

Warning: We do not recommend using QString::asprintf() in new Qt code. Instead, consider using QTextStream or arg(), both of which support Unicode strings seamlessly and are type-safe.

@patrickelectric
Copy link
Member Author

Both QTextStream and arg does not support cformat style.

@jaxxzer
Copy link
Collaborator

jaxxzer commented May 18, 2020

refactor is still possible, just ditch the format string and use precision parameter of arg to format the floats. NBD to me though, the small patch is nice.

@DonLakeFlyer
Copy link
Contributor

so anyone that is using a modern Qt version is unable to build QGC right now.

If you are doing that you are living in the territory of "unsupported". That said there should be an easier way to turn off warnings as errors. I'm in the middle of reworking all that. I'll fix it up. If you don't see it soon, ping me. I may forget. I've been out of town so lots of catchup to do.

@DonLakeFlyer DonLakeFlyer merged commit 48fc09e into mavlink:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants