Homebrew formula produces a debug build #1070

Closed
occivink opened this Issue Dec 26, 2016 · 4 comments

Projects

None yet

3 participants

@occivink
Contributor

I think the OSX users would rather have an optimized build by default.

@lenormf
Contributor
lenormf commented Dec 27, 2016

The Makefile produces a debug build by default on purpose, so that users who get a crash can post a stacktrace in the bug report. I think we should keep it that way from some more time, we would lose a lot of information by stripping symbols.

@occivink
Contributor

I think that's expected if you build it manually, but for distribution purposes it's doing a disservice to the users to ship non-optimized binaries. It's also normal for new users to check how well kakoune performs with hueg files and we don't want them to get a wrong impression of kakoune's performance.

@mawww
Owner
mawww commented Jan 3, 2017

I agree, the brew recipe is akin to installing through a package manager, I think it should build an optimized version.

@occivink
Contributor

Fixed as of 66ad1ff.

@occivink occivink closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment