Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir highlighter #1350

Merged
merged 3 commits into from May 12, 2017
Merged

Elixir highlighter #1350

merged 3 commits into from May 12, 2017

Conversation

zambal
Copy link
Contributor

@zambal zambal commented May 5, 2017

No description provided.

I dedicate any and all copyright interest in this software to the
public domain.  I make this dedication for the benefit of the public at
large and to the detriment of my heirs and successors.  I intend this
dedication to be an overt act of relinquishment in perpetuity of all
present and future rights to this software under copyright law.
@zambal zambal mentioned this pull request May 5, 2017

hook global WinSetOption filetype=elixir %{
set buffer tabstop 2
set buffer indentwidth 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these indentation settings mandatory in elixir code? If not it's better to let users set those as they see fit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, although I think most people work with these settings, there are no standard rules as for example in go and it's definitely not mandatory.

I'll add a commit without these indentation settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is done and I also cleaned up the file a bit and tweaked a few colors. If you see no other issues, I think this is good enough for basic Elixir support.

@lenormf
Copy link
Contributor

lenormf commented May 6, 2017

Should be fine, could you squash your intermediary commits into a single one please? So that there's basically one commit with a waiver and one with the Elixir support script?

@zambal
Copy link
Contributor Author

zambal commented May 6, 2017

Sure, I just squashed the commits.

@CosmicToast CosmicToast mentioned this pull request May 9, 2017
face ElixirSpecialKeyword blue+b
face ElixirEnv red+b
face ElixirOperator rgb:a8a8a8
face ElixirInterpolation rgb:00d7ff
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using custom faces here means colorschemes wont be redefining these. I think it will be better to use the generic ones (see for example colors/default.kak)

If you think we really need to introduce new generic ones, we can discuss that either here or on IRC, but I dont think adding filetype specific faces is the way to go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It felt a bit dirty to add them indeed, but I wanted to have a bit more colors to select from, but the fact different colorschemes are now effectively not supported for the Elixir highlighter is indeed not good.

I'll commit a version without the extra faces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like me to squash this commit into the previous commit too?

@mawww mawww merged commit 812af8c into mawww:master May 12, 2017
@zambal zambal deleted the elixir-highlighter branch May 12, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants