Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from nose to pytest #434

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@singingwolfboy
Copy link
Contributor

commented Jun 4, 2019

nose is unmaintained. Pytest is a much nicer, modern, supported test framework.

@coveralls

This comment has been minimized.

Copy link

commented Jun 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 48f04d2 on singingwolfboy:pytest into 77df4e6 on maxcountryman:master.

@singingwolfboy singingwolfboy force-pushed the singingwolfboy:pytest branch from bfaa09e to 671542f Jun 4, 2019

@maxcountryman maxcountryman requested a review from alanhamlett Jun 4, 2019

@maxcountryman

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

I'm in favor of switching to pytest--I think it would also be nice to update the tests to follow a better naming convention as well, but that doesn't have to be part of this transition.

@singingwolfboy singingwolfboy force-pushed the singingwolfboy:pytest branch from 7ceba42 to 48f04d2 Jun 4, 2019

@singingwolfboy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Is there anything preventing this from being merged?

@maxcountryman

This comment has been minimized.

Copy link
Owner

commented Jun 4, 2019

I was curious if @alanhamlett had any comments but it otherwise looks good to me.

@alanhamlett alanhamlett merged commit 620cf3d into maxcountryman:master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.