Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed buggy calls to bootstrap-sass #13

Merged
merged 1 commit into from

5 participants

@NZGlitch

There were 2 calls to gradient-vertical-three-colors where a value was given as a % when bootstrap-sass seems to prefer a decimal (i.e. 90% should be 0.9)

This was causing an error for me: '9000%*% is not a valid css.....'

I was using bootstrap-sass version 2.1.0.0

The bug exists in some other swatches as well.

@vojtisek

Oh man, you just saved me a few hours of my life. Surprisingly, I couldn't find any piece of information about this bug on the net. Good work and I hope that Maxim will take care of this soon.
Once again - thanks.

V.

@maxim
Owner

Verified, thanks!

@maxim maxim merged commit e9a6aac into from
This was referenced
@engunneer

This appears to be broken again.

@maxim
Owner

@engunneer Where exactly? Not all places need percentage as far as I understood. Are you on latest sass?

@engunneer

Specifically https://github.com/maxim/bootswatch-rails/blob/master/vendor/assets/stylesheets/bootswatch/cerulean/_bootswatch.scss#L127

I'm using Rails 3.2.12, sass 3.2.6, sass-rails 3.2.6, bootstrap-sass 2.1.0.0, bootswatch-rails 0.4.0. changing line 127 of cerulean from 5% to .05 worked for me.

Edit: I updated to Rails 3.2.12, sass 3.2.7, sass-rails 3.2.6, bootstrap-sass 2.3.1.0 and it still doesn't like the 5%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 13, 2012
  1. @NZGlitch
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 vendor/assets/stylesheets/bootswatch/cerulean/_bootswatch.scss
View
4 vendor/assets/stylesheets/bootswatch/cerulean/_bootswatch.scss
@@ -15,7 +15,7 @@
// -----------------------------------------------------
.navbar-inner {
- @include gradient-vertical-three-colors($navbarBackground, $navbarBackground, 90%, $navbarBackgroundHighlight);
+ @include gradient-vertical-three-colors($navbarBackground, $navbarBackground, .9, $navbarBackgroundHighlight);
}
.navbar .nav .active > a,
@@ -54,7 +54,7 @@
// -----------------------------------------------------
.btn {
- @include gradient-vertical-three-colors($white, $white, 5%, darken($white, 0%));
+ @include gradient-vertical-three-colors($white, $white, .05, darken($white, 0%));
$shadow: inset 0 1px 0 rgba(255,255,255,.2), 0 1px 2px rgba(0,0,0,.05);
@include box-shadow($shadow);
Something went wrong with that request. Please try again.