Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running any command after install #3

Closed
coltonfitzgerald opened this issue Apr 18, 2015 · 10 comments
Closed

Running any command after install #3

coltonfitzgerald opened this issue Apr 18, 2015 · 10 comments

Comments

@coltonfitzgerald
Copy link

@coltonfitzgerald coltonfitzgerald commented Apr 18, 2015

I ran "npm install gitclick -g" and any command I try and run for gitclick gives me this error:

/usr/local/lib/node_modules/gitclick/bin/gitclick:4
const path = require('path');
^^^^^
SyntaxError: Use of const in strict mode.
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 18, 2015

Hi @coltonfitzgerald! Thanks for the comment. It looks like the latest version of node.js does not support const yet. gitclick should work fine with io.js. Could you give that a try? I recommend checking out n to easily install node.js and io.js.

@bradcerasani

This comment has been minimized.

Copy link

@bradcerasani bradcerasani commented Apr 19, 2015

Seeing this too running node.js latest (v0.12.2)

While in theory there shouldn't be any conflict using io.js for day-to-day dev, not sure I want to just to use this module. Until there is reconciliation between node and io.js, you may want to consider adding support for v0.12.2 or specifying in the readme that this is currently io.js only.

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 19, 2015

Good point, @bradcerasani. I've added support for node.js through babel in gitclick version ^0.2.0. Let me know if that works!

@bradcerasani

This comment has been minimized.

Copy link

@bradcerasani bradcerasani commented Apr 19, 2015

Hmm, still seeing the same issue with gitclick v0.2.1 on node v0.12.2. Works fine on io v1.6.4

Demo (pardon the screenflow window): http://bpxl.io/qKvb/3OYYyeUo

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 19, 2015

Hey @bradcerasani. Thanks for the update and the screencast, that made it easy to reproduce. For me it works as expected with node v.0.12.2 when doing npm link but if I npm install gitclick -g it doesn't work either... I'll figure it out and post back here when I do. Thanks for helping out with the bug reports! :)

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 19, 2015

Ok @bradcerasani I think I finally fixed it with version 0.2.2:

screen shot 2015-04-19 at 22 19 41

If you have the time, can you check out if it works for you too? Thanks! :)

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 19, 2015

nevermind... there's still an issue. I'm sorry. :D

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 19, 2015

Ok, I just published 0.2.3. I am confident that it works now. It took me quite some time to figure out the issue, but I think I got it. Let me know if you get a chance to try it out, thanks again! :)

@bradcerasani

This comment has been minimized.

Copy link

@bradcerasani bradcerasani commented Apr 20, 2015

0.2.3 is working for me! Thanks Max

@maximilianschmitt

This comment has been minimized.

Copy link
Owner

@maximilianschmitt maximilianschmitt commented Apr 20, 2015

Awesome, I'm very glad to hear that. Thanks again for your help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.