Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Clarify statistical functionality of this package #18

Closed
mnarayan opened this issue Jan 21, 2019 · 3 comments
Closed

JOSS Review: Clarify statistical functionality of this package #18

mnarayan opened this issue Jan 21, 2019 · 3 comments

Comments

@mnarayan
Copy link

This relates to requirements stated in openjournals/joss-reviews#1169. Both statement of need and functionality provided by this software needs further clarification.

From reading the README and paper.md alone, I don't immediately understand what scikit-posthoc does compared to statsmodel's multiple testing functionality. It would be helpful to have one or two paragraphs explaining exactly which sorts of multiple testing scenarios an end user should use scikit-posthocs for rather than say just invoking the multiple testing functionality of statsmodels.

The PMCMR package in R has a lot more detail in its documentation. However, it seems they implement a number of use-cases that this package does not yet support.

@mnarayan
Copy link
Author

@maximtrp how is this going?

@maximtrp
Copy link
Owner

@mnarayan Please check out the current state of this repo and its documentation.

@mnarayan
Copy link
Author

The new examples and figures are great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants