From 5f1334b7d9258836460658402218ef6089ffe395 Mon Sep 17 00:00:00 2001 From: Max Starikov Date: Sat, 8 Aug 2026 19:54:53 +0200 Subject: [PATCH] delete old deploy --- .github/workflows/android-deploy.yml | 50 ---------------------------- fastlane/Fastfile | 6 ---- scripts/test_release_workflows.py | 6 +++- 3 files changed, 5 insertions(+), 57 deletions(-) delete mode 100644 .github/workflows/android-deploy.yml diff --git a/.github/workflows/android-deploy.yml b/.github/workflows/android-deploy.yml deleted file mode 100644 index ca44707..0000000 --- a/.github/workflows/android-deploy.yml +++ /dev/null @@ -1,50 +0,0 @@ -name: Android Build & Deploy - -on: - workflow_dispatch: - -permissions: - contents: read - -jobs: - deploy: - runs-on: ubuntu-latest - environment: release - steps: - - uses: actions/checkout@v6 - - - name: set up JDK 17 - uses: actions/setup-java@v5 - with: - java-version: '17' - distribution: 'temurin' - cache: gradle - - - name: Set up ruby env - uses: ruby/setup-ruby@v1 - with: - ruby-version: '3.3' - bundler-cache: true - - - name: Setup Properties - run: cp fastlane/Appfile.deploy Appfile - - - name: Decode Service Account Key JSON File - run: echo "${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT }}" | base64 -d > service_account_key.json - - - name: Decode Keystore File - run: echo "${{ secrets.ANDROID_KEYSTORE_BASE64 }}" | base64 -d > android_keystore.jks - - - name: Run tests - run: bundle exec fastlane android test - env: - ANDROID_KEYSTORE: "../android_keystore.jks" - - - name: Build & deploy Android release - run: bundle exec fastlane android deploy - env: - ALLOW_LEGACY_PRODUCTION: "true" - ANDROID_KEYSTORE: "../android_keystore.jks" - KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }} - KEY_ALIAS: ${{ secrets.KEY_ALIAS}} - KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }} diff --git a/fastlane/Fastfile b/fastlane/Fastfile index bb65b94..f5c85fc 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -118,10 +118,4 @@ platform :android do ) end - desc "Legacy direct production deploy retained only until the protected release rehearsal succeeds" - lane :deploy do - UI.user_error!("Set ALLOW_LEGACY_PRODUCTION=true only for the documented emergency path") unless ENV["ALLOW_LEGACY_PRODUCTION"] == "true" - gradle(task: "clean assembleRelease") - upload_to_play_store(track: "production", release_status: "completed") - end end diff --git a/scripts/test_release_workflows.py b/scripts/test_release_workflows.py index 6555da5..8e0fddc 100644 --- a/scripts/test_release_workflows.py +++ b/scripts/test_release_workflows.py @@ -81,10 +81,14 @@ def test_fastlane_handles_empty_google_play_tracks(self): "create-release.yml", "tagged-release.yml", "promote-production.yml", - "android-deploy.yml", ): self.assertIn("ruby-version: '3.3'", self.read(name)) + def test_legacy_direct_production_deploy_is_removed(self): + self.assertFalse((WORKFLOWS / "android-deploy.yml").exists()) + fastfile = (ROOT / "fastlane" / "Fastfile").read_text(encoding="utf-8") + self.assertNotIn("ALLOW_LEGACY_PRODUCTION", fastfile) + if __name__ == "__main__": unittest.main()