New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xapian in mailman-web #286

Merged
merged 2 commits into from Jan 20, 2019

Conversation

Projects
None yet
2 participants
@pgeorgi
Copy link

pgeorgi commented Jan 11, 2019

No description provided.

@maxking
Copy link
Owner

maxking left a comment

I am okay with adding xapian to the image, but I am not sure we need the rest of the changes made in this image.

I have added a few inline comments.

Show resolved Hide resolved web/Dockerfile Outdated
Show resolved Hide resolved web/Dockerfile Outdated
Show resolved Hide resolved web/Dockerfile Outdated

@pgeorgi pgeorgi force-pushed the pgeorgi:xapian branch 2 times, most recently from f776d25 to c8a0148 Jan 12, 2019

@maxking

This comment has been minimized.

Copy link
Owner

maxking commented Jan 16, 2019

Can you also rebase off the master? I bumped Django and MailmanClient in master.

Patrick Georgi added some commits Jan 11, 2019

Patrick Georgi
Use standard alpine image as base for mailman-web
This way we can depend on alpine's python3 package which is binary
compatible with the rest of the python packages in the distribution.

This requires spelling out python3 explicitly in several places since
alpine still defaults to python 2 for /usr/bin/python.
Patrick Georgi
Add xapian to the mailman-web container
Whoosh completely breaks down on 4GB of mail archives, so provide xapian
as an alternative. It's not hooked up automatically, but can be enabled
in the config files.

Related to issue #97.

@pgeorgi pgeorgi force-pushed the pgeorgi:xapian branch from c8a0148 to 51a5485 Jan 16, 2019

@pgeorgi

This comment has been minimized.

Copy link
Author

pgeorgi commented Jan 16, 2019

Can you also rebase off the master? I bumped Django and MailmanClient in master.

done.

@maxking

This comment has been minimized.

Copy link
Owner

maxking commented Jan 17, 2019

Thanks very much for your fixes!

I am gonna try out this change locally and then merge it. This is first time we are bumping to alpine 3.8, so I just want to be extra cautious since a few people do use the rolling releases generated daily :)

@maxking maxking merged commit c1dabd0 into maxking:master Jan 20, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment