Add support for getting the prefix length when looking up an IP #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a small performance improvement.
The reason for doing this now is that the code was already untidy according to uncrustify. Given this, I took the opportunity to switch to clang-format given that is the direction we have been moving in other repos.
horgh
requested changes
Sep 24, 2019
Contributor
horgh
left a comment
horgh
left a comment
There was a problem hiding this comment.
Great! Just a couple minor things I noticed.
extension/maxminddb.c
Outdated
| }; | ||
| static PyMethodDef Metadata_methods[] = {{NULL, NULL, 0, NULL}}; | ||
|
|
||
| /* *INDENT-OFF* */ |
Contributor
There was a problem hiding this comment.
We could remove these comments I think?
extension/maxminddb.c
Outdated
| static PyTypeObject Metadata_Type = { | ||
| PyVarObject_HEAD_INIT(NULL, 0) | ||
| .tp_basicsize = sizeof(Metadata_obj), | ||
| PyVarObject_HEAD_INIT(NULL, 0).tp_basicsize = sizeof(Metadata_obj), |
Contributor
There was a problem hiding this comment.
Hrm, this isn't great. I saw one like this above (first file in the commit) as well, though not as weird.
| PyErr_SetString( | ||
| PyExc_RuntimeError, | ||
| "getaddrinfo was successful but failed to set the addrinfo"); | ||
| return 0; |
horgh
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.