New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method and parameter names in eg/freeze-thaw #97

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@jjatria
Contributor

jjatria commented Jul 31, 2018

Running the script in eg/freeze-thaw resulted in a deprecation warning regarding the merge_record_collisions parameter to the tree constructor, and a crash when calling from_frozen_tree.

This patch fixes these by replacing the constructor parameter with merge_strategy => 'toplevel' and calling new_from_frozen_tree instead.

@oschwald

This comment has been minimized.

Show comment
Hide comment
@oschwald

oschwald Jul 31, 2018

Member

Thanks! 👍

Member

oschwald commented Jul 31, 2018

Thanks! 👍

@oschwald oschwald merged commit a15acce into maxmind:master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment