Fix "Closed stream" exception in getDatabaseInfo() #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

vineus commented Jan 9, 2013

happening when using GEOIP_MEMORY_CACHE option

Vincent de Lagabbe Fix "Closed stream" exception in getDatabaseInfo()
happening when using GEOIP_MEMORY_CACHE option
106314c

i don't see this pull request merged. does anyone know if it was approved or rejected?

i see some line spacing/coding standard issues, since it changed a number of lines.

vineus commented Aug 28, 2013

Hey,

No, no one merged it and apparently nobody cares :-) We were tired of waiting so we forked it and fixed some other minor bugs: https://github.com/criteo/geoip-api-csharp2

Owner

oschwald commented Aug 28, 2013

I apologize. Most of our focus has been on GeoIP2 recently. If you submit a pull requests with your bug fixes, we will probably accept them as long as they seem reasonable and don't change the external API.

vineus commented Aug 31, 2013

No problem, I'll prepare that! Thanks!

Contributor

borisz commented Sep 3, 2013

Hi Vineus,
Does bz/fix-dbinfo work for you?
Nothing is wrong with your patch, but the other solution is simpler.

Owner

oschwald commented Sep 4, 2013

Thanks for reporting this. We believe this has been fixed in master. Please let us know if you still experience the issue.

oschwald closed this Sep 4, 2013

vineus commented Sep 4, 2013

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment