happening when using GEOIP_MEMORY_CACHE option
Fix "Closed stream" exception in getDatabaseInfo()
i don't see this pull request merged. does anyone know if it was approved or rejected?
i see some line spacing/coding standard issues, since it changed a number of lines.
No, no one merged it and apparently nobody cares :-) We were tired of waiting so we forked it and fixed some other minor bugs: https://github.com/criteo/geoip-api-csharp2
I apologize. Most of our focus has been on GeoIP2 recently. If you submit a pull requests with your bug fixes, we will probably accept them as long as they seem reasonable and don't change the external API.
No problem, I'll prepare that! Thanks!
Does bz/fix-dbinfo work for you?
Nothing is wrong with your patch, but the other solution is simpler.
Thanks for reporting this. We believe this has been fixed in master. Please let us know if you still experience the issue.
Thanks a lot!