Fix Pages deploy: rename workflow, tighten permissions#9
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Rename .github/workflows/ghpages.yml to pages.yml to match the libmaxminddb/mod_maxminddb/geoipupdate convention (Greg's STF-448 migration). Tighten permissions to least-privilege per job: drop the unused pages:write from the build job (deploy already has it, along with the id-token:write needed for OIDC). Build job now has contents:read only. Drop the enablement:true flag from configure-pages which was causing every main push to fail at "Resource not accessible by integration" — the GITHUB_TOKEN lacks repo-admin scope to create the Pages site, but the site is now already enabled so the flag is no longer needed. Restrict the push trigger to branches: ["main"] so feature-branch pushes don't fire the workflow with a deploy job that gets rightly rejected by the github-pages environment's branch protection. PR-build trigger and path-ignored filters are retained so dependabot bumps continue to validate the draft compiles before merging to main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
klp2
force-pushed
the
kphair/stf-264-pages-workflow-fix
branch
from
82f8f8b to
30801e5
Compare
oschwald
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ghpages.yml→pages.ymlto match the libmaxminddb / mod_maxminddb / geoipupdate convention (Greg's STF-448 migration).enablement: truefromactions/configure-pages— the root cause of every recentmain-push failure withResource not accessible by integration. The Pages site is already enabled, soconfigure-pageswill GET it cleanly without trying to POST.pages: writefrom the build job (deploy already has it, along withid-token: write). Build job now hascontents: readonly.Validation
mainshould now reach thedeployjob and complete.gh api repos/maxmind/ipfeed-draft/pagesshould reportstatus: "built"(currentlynull).For STF-264.
🤖 Generated with Claude Code