Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to extract directories (for some zips) #10

Closed
mal opened this issue Sep 16, 2015 · 4 comments
Closed

Fails to extract directories (for some zips) #10

mal opened this issue Sep 16, 2015 · 4 comments

Comments

@mal
Copy link

mal commented Sep 16, 2015

Noticed here: electron-userland/electron-prebuilt#57 (comment)

Example zip: https://github.com/atom/electron/releases/download/v0.32.3/electron-v0.32.3-linux-x64.zip

This appears to stem from whether a directory is included in the zip's manifest(?).

test/cats.zip

[...]
/tmp/cat-extract-test/cats/
/tmp/cat-extract-test/cats/.DS_Store
/tmp/cat-extract-test/cats/deema3.5771930_std.JPG
/tmp/cat-extract-test/cats/Deema_019.204205705_std.jpg
/tmp/cat-extract-test/cats/empty/
/tmp/cat-extract-test/cats/gJqEYBs.jpg
/tmp/cat-extract-test/cats/orange/
[...]

vs

electron-v0.32.3-linux-x64.zip

[...]
/tmp/elec-extract-test/libgcrypt.so.11
/tmp/elec-extract-test/libnotify.so.4
/tmp/elec-extract-test/resources/atom.asar
[...]

Note the lack of a /tmp/elec-extract-test/resources/.

@mal mal changed the title Fails to extract directories Fails to extract directories (for some zips) Sep 16, 2015
@ducky427
Copy link

I've also just come across this bug via the exact same sequence.

@max-mapper
Copy link
Owner

Oops my bad, working on a fix now

@max-mapper
Copy link
Owner

fixed in 1.1.1

@mal
Copy link
Author

mal commented Sep 16, 2015

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants