Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe inputs and crashes #2

Closed
maxscheurer opened this issue Nov 26, 2016 · 1 comment
Closed

Safe inputs and crashes #2

maxscheurer opened this issue Nov 26, 2016 · 1 comment
Assignees
Milestone

Comments

@maxscheurer
Copy link
Owner

User inputs are not checked for validity at the moment.

@maxscheurer maxscheurer added this to the Beta version milestone Nov 26, 2016
@maxscheurer maxscheurer assigned maxscheurer and ghost Nov 26, 2016
@maxscheurer maxscheurer assigned maxscheurer and ghost and unassigned maxscheurer and ghost Jan 5, 2017
@maxscheurer
Copy link
Owner Author

maxscheurer commented Jan 6, 2017

List of problems:

Crashes 🔥

  • clicking on Statistics when no data is loaded
  • creating TCL script when no data is loaded
  • Cancelling "Export session" (if no data loaded?)
    if self.contacts is not None and self.analysis is not None: AttributeError: 'MainWindow' object has no attribute 'analysis'
  • Cancelling "Import session"
    line 165: importDict = pickle.load(open(importfile, "rb")) should not be called
  • Sasa calculate button check input

Inputs 💻

  • check for numbers in Analyze/Input text fields (sometimes QValidator is good to use)

@maxscheurer maxscheurer changed the title Safe inputs Safe inputs and crashes Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant