Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL error, maybe you should add option to "ignore" SSL exception #1

Closed
metal3d opened this issue Jan 23, 2014 · 6 comments
Closed

SSL error, maybe you should add option to "ignore" SSL exception #1

metal3d opened this issue Jan 23, 2014 · 6 comments
Assignees
Labels

Comments

@metal3d
Copy link

@metal3d metal3d commented Jan 23, 2014

Tryign to connect our redmine server:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/redmine/managers.py", line 98, in get
    return self.resource_class(self, self.retrieve())
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/redmine/managers.py", line 76, in retrieve
    return self.redmine.request('get', self.url, params=self.params)[self.container]
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/redmine/__init__.py", line 68, in request
    response = getattr(requests, method)(url, **kwargs)
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/requests/api.py", line 55, in get
    return request('get', url, **kwargs)
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
    r = adapter.send(request, **kwargs)
  File "/home/pafer/src/redmineadm/venv/lib/python2.7/site-packages/requests/adapters.py", line 389, in send
    raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

Or maybe you've got other solution ? :)

@metal3d
Copy link
Author

@metal3d metal3d commented Jan 23, 2014

I did a little manipulation in redmine/init.py, I append verify: False in the kwords (line 53).

So, maybe appending another kargument "sslverify" for the "request" method can be simple... I can provide a patch... But I need time :)

@maxtepkeev
Copy link
Owner

@maxtepkeev maxtepkeev commented Jan 23, 2014

Hi!

Thanks for the report.

Please try v0.3.1, I added a requests keyword argument where you can pass any Requests options, in your case it would be:

redmine = Redmine('https://redmine.url', requests={'verify': False})

I also updated documentation, maybe you will want to have a look at it.

Please let me know if everything works as expected. Thanks.

@ghost ghost assigned maxtepkeev Jan 23, 2014
@metal3d
Copy link
Author

@metal3d metal3d commented Jan 28, 2014

OK thanks. I'll test this later... The problem is that at this time we
cannot use this lib because there is no write operation.
I can try anyway to help developpement :)

Le 23 janv. 2014 14:05, "Max Tepkeev" notifications@github.com a écrit :

Hi!

Thanks for the report.

Please try v0.3.1, I added a requests keyword argument where you can pass
any Requests options, in your case it would be:

redmine = Redmine('https://redmine.url', requests={'verify': False})

I also updated documentation, maybe you will also want to have a look at
it.

Please let me know if everything works as expected. Thanks.


Reply to this email directly or view it on GitHub.

@maxtepkeev
Copy link
Owner

@maxtepkeev maxtepkeev commented Jan 28, 2014

Create operations are already implemented, update operations are expected in the next version. Hopefully everything will be done by the end of January.

I'll appreciate if you test the SSL problem you had and report if everything works so we could close this issue. Thanks.

@metal3d
Copy link
Author

@metal3d metal3d commented Jan 28, 2014

Yes, I meant "update" operations.
I'll try SSL at week end. No problem.
Le 28 janv. 2014 07:53, "Max Tepkeev" notifications@github.com a écrit :

Create operations are already implemented, update operations are expected
in the next version. Hopefully everything will be done by the end of
January.

I'll appreciate if you test the SSL problem you had and report if
everything works so we could close this issue. Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-33455216
.

@maxtepkeev
Copy link
Owner

@maxtepkeev maxtepkeev commented Feb 8, 2014

Tested. Everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.