New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests directory to source tarball #108

Closed
bdrung opened this Issue Oct 8, 2015 · 6 comments

Comments

2 participants
@bdrung
Contributor

bdrung commented Oct 8, 2015

Please add the tests directory to source tarball, since we use that for the Debian package. Otherwise the tests cannot be run from the source tarball.

@maxtepkeev maxtepkeev self-assigned this Oct 9, 2015

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Oct 9, 2015

Hi Benjamin,

You mean the tarball which you get from PyPI, like this one for v1.2.0 ?

@bdrung

This comment has been minimized.

Contributor

bdrung commented Oct 10, 2015

Yes, exactly.

maxtepkeev added a commit that referenced this issue Oct 18, 2015

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Oct 18, 2015

Done.

You can now also use python setup.py test command which will figure out all the dependencies needed for running tests on the current system and after installing them if they are not here it will run the tests.

Also starting from v1.4.0 requests are now bundled with Python-Redmine and will be updated as needed. That will make package much more stable.

Let me know if everything works for you as it should.

@bdrung

This comment has been minimized.

Contributor

bdrung commented Oct 18, 2015

Please do not bundle needed libraries into your package. The Debian package will always use python-request from the system. Bundled libraries have the drawback that they increases the source package size and that I have to document also their license.

See also https://wiki.debian.org/UpstreamGuide#No_inclusion_of_third_party_code

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Oct 19, 2015

I'm sorry but I fully disagree.

  1. Python-Redmine uses relative imports which means that it will always use the bundled Requests library and not the one from the system or from virtualenv or another one installed elsewhere.
  2. The size of the package increased by a few hundred kilobytes which is nothing in the current world of terabytes.
  3. The license of the bundled package is already included with Python-Redmine (see NOTICE).

Python-Redmine exists for more than 1.5 years now and I had several bug reports connected with the wrong Requests library version on the system, which was very hard to identify. Also, a lot of packages bundle other packages and that is a fact of life, because bundling makes the developer life easier and it also provides users of the package with the best possible experience. For example take the Requests library, it bundles chardet and urllib3 packages, and urllib3 also bundles ordered_dict, six and ssl_match_hostname packages. There was already the same discussion about the Requests library, you can see it here, I agree with everything that was said in there so I'm not going to repeat the same things.

I really appreciate your work for making Python-Redmine available in Debian and Ubuntu, but bundling libraries makes life better, not worse, that is why I'm not going to change my mind about this.

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Oct 20, 2015

@bdrung There is an ongoing discussion in the #109 about whether it was a good idea to bundle python-requests and I have a proposal to make everybody happy, I would appreciate to hear your thoughts about it in the #109. Thanks.

I'm closing this issue because it is related to tests and we figured everything about them already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment