New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix over 100 tickets problem in issue.filter #175

Merged
merged 1 commit into from Apr 19, 2017

Conversation

3 participants
@niwatolli3
Contributor

niwatolli3 commented Apr 15, 2017

When I execute redmine.issue.filter(tracker_id=3), I found the following problem.

import unittest

import logging

import sys

from redminelib import Redmine


class Over100TicketsTest(unittest.TestCase):
    def setUp(self):
        pass

    def test_over100_tickets(self):
        redmine = Redmine(url="http://www.redmine.org/projects/redmine")
        issues = redmine.issue.filter(project_id=1, tracker_id=3)
        for i, issue in enumerate(issues):
            print("%d, #%d [%s] %s" % (i, issue.id, issue.tracker.name, issue))
            self.assertEqual("Patch", issue.tracker.name)

if __name__ == "__main__":
    logging.basicConfig( stream=sys.stderr )
    unittest.main()

Result

/Users/tomi/.virtualenvs/python-redmine-bugfix/bin/python /Users/tomi/repos/python-redmine/tests/test_over100.py
0, #25570 [Patch] unchecked use of params[:query]
1, #25491 [Patch] List of role members
2, #25445 [Patch] unify email notifications
3, #25402 [Patch] stop misusing distance_in_words
4, #25381 [Patch] Allow project selection when editing timelog entries
5, #25265 [Patch] QueriesController can not handle subclass of IssueQuery
6, #25261 [Patch] Patch for bug with call_hook in mail handler
7, #25154 [Patch] Allow non-administrator users to copy certain projects
8, #25139 [Patch] Project link on issues list, now redirects to project specific issues
9, #25114 [Patch] Context menu positioning inside positioned DOM elements
10, #25068 [Patch] Versions show page summary moved to sidebar
11, #25066 [Patch] Sort order with null placement (NULLS FIRST, NULLS LAST)
12, #24939 [Patch] Changing plugin loading order
13, #24837 [Patch] Bulk update issues with author
14, #24827 [Patch] Project roadmap each version now wrapped with "box" class
15, #24623 [Patch] Implements permissions and restrictions to issue attachments
16, #24581 [Patch] Save spent time filters in session in order to have the same behaviour as for issue filters
17, #24446 [Patch] Call `view_issues_timelog_form_bottom` hook
18, #24435 [Patch] Add `view_account_contextual` and `view_account_list_buttons` hooks
19, #24434 [Patch] Link Redmine Issues to Mercurial Branch name
20, #24323 [Patch] Improve exceptions handling
21, #24268 [Patch] Wrong german translation of error message
22, #24072 [Patch] Added formatting for email notifications
23, #24051 [Patch] As a non-admin user using API, I want to be able to filter users by their username without getting forbidden exception
24, #24007 [Patch] Change plugins directory through the configuration.yml file
25, #24005 [Patch] Reject over 24 hours on time entry
26, #23997 [Patch] Per role visibility settings for project and version custom fields
27, #23980 [Patch] Replace images with icon fonts
28, #23954 [Patch] Shows the date of the last activity on Projects administration.
29, #23946 [Patch] News appearance with box class
30, #23645 [Patch] Fix Gantt PDF rendering for single-day tasks
31, #23546 [Patch] Issue visibility "watched by, created by or assigned to" for roles
32, #23498 [Patch] Add plugin view hook for wiki context menu
33, #23417 [Patch] Make the ID column configurable in the issues listing like the other columns
34, #23378 [Patch] Speedup Project Settings with many members
35, #23328 [Patch] Improve Update/Create issue speed
36, #22913 [Patch] Auto-select fields mapping in Importing
37, #22798 [Patch] fetching of Git changesets sometimes fails due to non existant revisions in prev_db_heads
38, #22291 [Patch] Link Category in the issue page to all open issues from that project with the same category
39, #22112 [Patch] add html5 audio controls if attachment is mp3
40, #21841 [Patch] Correctly export collections associated with issues.
41, #21808 [Patch] Make the Sidebar collapsible, stateful
42, #21550 [Patch] New option in html redmine link parsing - attachments
43, #21493 [Patch] Tweak colors of default theme
44, #21378 [Patch] Include Documents in Projects API
45, #21257 [Patch] Use PDF icon for "Also available in PDF"
46, #21101 [Patch] Add go-to action schema
47, #21057 [Patch] Update and extend Gantt module wiki documentation
48, #21055 [Patch] Add Authentication mode filter in the Users admin page
49, #20888 [Patch] Add a button in the textile formatting toolbar to convert tabulated text into a table
50, #20687 [Patch] Quota Issues
51, #20384 [Patch] Proposal: Workflow enhancement
52, #20287 [Patch] Administration: Using grids instead of tables
53, #20263 [Patch] Redmine load hook
54, #20124 [Patch] Query option, The sql for field to allow groups option.
55, #20121 [Patch] Respect working days configuration when sending reminder emails
56, #20063 [Patch] Add  "issue#" syntax for issue links
57, #19742 [Patch] RedmineInstall: MySQL: collation_database
58, #19622 [Patch] Filter previous *status / assigned_to / priority / tracker* [ + date ranges ]
59, #19520 [Patch] LDAP authentication exception handling
60, #19370 [Patch] Parent projects in project jump dropdown
61, #19242 [Patch] Patch to the Redmine Mail Handler for overriding the sender, and adding custom header/footers to imported e-mails
62, #19188 [Patch] Add Hooks to Issue Show View above and below floating changesets
63, #19108 [Patch] Ability to limit search to last week/month/year
64, #18868 [Patch] Add support for queries with 'next week' filter
65, #18778 [Patch] Add new alias for issue note links ('comment')
66, #18770 [Patch] Make issue history collapsable
67, #18681 [Patch] Issue list api : journals, watchers
68, #18496 [Patch] Migrate to Redmine 2.5.3 (or 2.6.0) from Mantis 1.2.17
69, #18419 [Patch] Copy news along with the project
70, #18326 [Patch] Show associated revisions in issue list query column
71, #18209 [Patch] Add e-mail notification option: Tracker updated
72, #18134 [Patch] Issues with svn:mergeinfo property values and r13443 rails-4.1 rebase.
73, #18059 [Patch] Activity when issue change assigned to.
74, #18001 [Patch] Migration from highly customized Mantis 1.2.11 with inheritable categories in redmine
75, #17973 [Patch] Portuguese jQuery Datepicker translation file
76, #17971 [Patch] Issue tables : highlight issues of level 0
77, #17947 [Patch] Mirror relation
78, #17924 [Patch] Structured Document list for more flexible UI design with CSS
79, #17900 [Patch] Allow change value of the time_entry object via controller_issues_edit_before_save hook from a plugin
80, #17748 [Patch] Subrepositories Fail to Authenticate Internal Users upon Subversion Checkout
81, #17718 [Patch] Body delimiters to truncate emails do not take uncommon whitespace into account
82, #17699 [Patch] Parse email with header "From" in parentheses format
83, #17368 [Patch] Enable encrypted LDAP passwords with Redmine.pm
84, #17303 [Patch] Vietnamese language pack
85, #17088 [Patch] call hook for repository edit form
86, #16730 [Patch] Fix ordering in ApplicationHelper method principals_options_for_select
87, #16719 [Patch] Redmine.pm patch for HTTP access of repositories by repo-name
88, #16446 [Patch] Generate full URLs to images and linked pages in the Wiki HTML export
89, #16364 [Patch] Issue workflow doesn't force status transition though workflow is defined so
90, #16314 [Patch] Redirect back is overheated
91, #16313 [Patch] Allow to link to an achor of the current wikipage
92, #16133 [Patch] Available watchers on new issue form include users who cannot even view issues
93, #16116 [Patch] Sort of version options
94, #16087 [Patch] Markdown renderer doesn’t clean HTML properly
95, #16069 [Patch] Allow configuration of API limit instead of hardcoding at 100
96, #16045 [Patch] Add "Previous Assignee" entry when changing issue assignee
97, #16042 [Patch] Nicer overview boxes
98, #16006 [Patch] Forum post notification does not include attachments
99, #15986 [Patch] Hook for REST API
100, #24884 [Feature] Allow to set which fields should be visible for child issue on their's parent issue
F/Users/tomi/.pyenv/versions/3.5.2/lib/python3.5/unittest/case.py:628: ResourceWarning: unclosed 
  outcome.errors.clear()

======================================================================
FAIL: test_over100_tickets (__main__.Over100TicketsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/tomi/repos/python-redmine/tests/test_over100.py", line 19, in test_over100_tickets
    self.assertEqual("Patch", issue.tracker.name)
AssertionError: 'Patch' != 'Feature'
- Patch
+ Feature


----------------------------------------------------------------------
Ran 1 test in 8.850s

FAILED (failures=1)

Process finished with exit code 1

(NG) the result contains ticket whose tracker_id is "Feature" (←is not "Patch")
(OK) the result only contains tickets whose tracker_id is "Patch"

  • Fixes
    I found a problem in redminelib/engines/base.py.
    variable balk_params is not passed filter condition, so I fixed it.

  • Test Results

/Users/tomi/.virtualenvs/python-redmine-bugfix/bin/python /Users/tomi/repos/python-redmine/tests/test_over100.py
0, #25570 [Patch] unchecked use of params[:query]
1, #25491 [Patch] List of role members
2, #25445 [Patch] unify email notifications
3, #25402 [Patch] stop misusing distance_in_words
4, #25381 [Patch] Allow project selection when editing timelog entries
5, #25265 [Patch] QueriesController can not handle subclass of IssueQuery
6, #25261 [Patch] Patch for bug with call_hook in mail handler
7, #25154 [Patch] Allow non-administrator users to copy certain projects
8, #25139 [Patch] Project link on issues list, now redirects to project specific issues
9, #25114 [Patch] Context menu positioning inside positioned DOM elements
10, #25068 [Patch] Versions show page summary moved to sidebar
11, #25066 [Patch] Sort order with null placement (NULLS FIRST, NULLS LAST)
12, #24939 [Patch] Changing plugin loading order
13, #24837 [Patch] Bulk update issues with author
14, #24827 [Patch] Project roadmap each version now wrapped with "box" class
15, #24623 [Patch] Implements permissions and restrictions to issue attachments
16, #24581 [Patch] Save spent time filters in session in order to have the same behaviour as for issue filters
17, #24446 [Patch] Call `view_issues_timelog_form_bottom` hook
18, #24435 [Patch] Add `view_account_contextual` and `view_account_list_buttons` hooks
19, #24434 [Patch] Link Redmine Issues to Mercurial Branch name
20, #24323 [Patch] Improve exceptions handling
21, #24268 [Patch] Wrong german translation of error message
22, #24072 [Patch] Added formatting for email notifications
23, #24051 [Patch] As a non-admin user using API, I want to be able to filter users by their username without getting forbidden exception
24, #24007 [Patch] Change plugins directory through the configuration.yml file
25, #24005 [Patch] Reject over 24 hours on time entry
26, #23997 [Patch] Per role visibility settings for project and version custom fields
27, #23980 [Patch] Replace images with icon fonts
28, #23954 [Patch] Shows the date of the last activity on Projects administration.
29, #23946 [Patch] News appearance with box class
30, #23645 [Patch] Fix Gantt PDF rendering for single-day tasks
31, #23546 [Patch] Issue visibility "watched by, created by or assigned to" for roles
32, #23498 [Patch] Add plugin view hook for wiki context menu
33, #23417 [Patch] Make the ID column configurable in the issues listing like the other columns
34, #23378 [Patch] Speedup Project Settings with many members
35, #23328 [Patch] Improve Update/Create issue speed
36, #22913 [Patch] Auto-select fields mapping in Importing
37, #22798 [Patch] fetching of Git changesets sometimes fails due to non existant revisions in prev_db_heads
38, #22291 [Patch] Link Category in the issue page to all open issues from that project with the same category
39, #22112 [Patch] add html5 audio controls if attachment is mp3
40, #21841 [Patch] Correctly export collections associated with issues.
41, #21808 [Patch] Make the Sidebar collapsible, stateful
42, #21550 [Patch] New option in html redmine link parsing - attachments
43, #21493 [Patch] Tweak colors of default theme
44, #21378 [Patch] Include Documents in Projects API
45, #21257 [Patch] Use PDF icon for "Also available in PDF"
46, #21101 [Patch] Add go-to action schema
47, #21057 [Patch] Update and extend Gantt module wiki documentation
48, #21055 [Patch] Add Authentication mode filter in the Users admin page
49, #20888 [Patch] Add a button in the textile formatting toolbar to convert tabulated text into a table
50, #20687 [Patch] Quota Issues
51, #20384 [Patch] Proposal: Workflow enhancement
52, #20287 [Patch] Administration: Using grids instead of tables
53, #20263 [Patch] Redmine load hook
54, #20124 [Patch] Query option, The sql for field to allow groups option.
55, #20121 [Patch] Respect working days configuration when sending reminder emails
56, #20063 [Patch] Add  "issue#" syntax for issue links
57, #19742 [Patch] RedmineInstall: MySQL: collation_database
58, #19622 [Patch] Filter previous *status / assigned_to / priority / tracker* [ + date ranges ]
59, #19520 [Patch] LDAP authentication exception handling
60, #19370 [Patch] Parent projects in project jump dropdown
61, #19242 [Patch] Patch to the Redmine Mail Handler for overriding the sender, and adding custom header/footers to imported e-mails
62, #19188 [Patch] Add Hooks to Issue Show View above and below floating changesets
63, #19108 [Patch] Ability to limit search to last week/month/year
64, #18868 [Patch] Add support for queries with 'next week' filter
65, #18778 [Patch] Add new alias for issue note links ('comment')
66, #18770 [Patch] Make issue history collapsable
67, #18681 [Patch] Issue list api : journals, watchers
68, #18496 [Patch] Migrate to Redmine 2.5.3 (or 2.6.0) from Mantis 1.2.17
69, #18419 [Patch] Copy news along with the project
70, #18326 [Patch] Show associated revisions in issue list query column
71, #18209 [Patch] Add e-mail notification option: Tracker updated
72, #18134 [Patch] Issues with svn:mergeinfo property values and r13443 rails-4.1 rebase.
73, #18059 [Patch] Activity when issue change assigned to.
74, #18001 [Patch] Migration from highly customized Mantis 1.2.11 with inheritable categories in redmine
75, #17973 [Patch] Portuguese jQuery Datepicker translation file
76, #17971 [Patch] Issue tables : highlight issues of level 0
77, #17947 [Patch] Mirror relation
78, #17924 [Patch] Structured Document list for more flexible UI design with CSS
79, #17900 [Patch] Allow change value of the time_entry object via controller_issues_edit_before_save hook from a plugin
80, #17748 [Patch] Subrepositories Fail to Authenticate Internal Users upon Subversion Checkout
81, #17718 [Patch] Body delimiters to truncate emails do not take uncommon whitespace into account
82, #17699 [Patch] Parse email with header "From" in parentheses format
83, #17368 [Patch] Enable encrypted LDAP passwords with Redmine.pm
84, #17303 [Patch] Vietnamese language pack
85, #17088 [Patch] call hook for repository edit form
86, #16730 [Patch] Fix ordering in ApplicationHelper method principals_options_for_select
87, #16719 [Patch] Redmine.pm patch for HTTP access of repositories by repo-name
88, #16446 [Patch] Generate full URLs to images and linked pages in the Wiki HTML export
89, #16364 [Patch] Issue workflow doesn't force status transition though workflow is defined so
90, #16314 [Patch] Redirect back is overheated
91, #16313 [Patch] Allow to link to an achor of the current wikipage
92, #16133 [Patch] Available watchers on new issue form include users who cannot even view issues
93, #16116 [Patch] Sort of version options
94, #16087 [Patch] Markdown renderer doesn’t clean HTML properly
95, #16069 [Patch] Allow configuration of API limit instead of hardcoding at 100
96, #16045 [Patch] Add "Previous Assignee" entry when changing issue assignee
97, #16042 [Patch] Nicer overview boxes
98, #16006 [Patch] Forum post notification does not include attachments
99, #15986 [Patch] Hook for REST API
100, #15982 [Patch] Inconsitent wiki history functionaility
101, #15975 [Patch] Migrating from trac, parsing of headings is too greedy
102, #15906 [Patch] Create a default forum by default
103, #15819 [Patch] Migrating from trac, mysql2-query is defect
104, #15616 [Patch] Add a permission setting allowing members to delete their own projects
105, #15565 [Patch] Sidebar css
106, #15390 [Patch] Simple Redmine Sub-directory Support
107, #15234 [Patch] A popup message after session timeout
108, #15153 [Patch] Show more information about subtasks
109, #15118 [Patch] Deprecate and rename rss_* methods to atom_* methods
110, #14971 [Patch] Plugin rollback migration
111, #14862 [Patch] Documents get paging and export functions 
112, #14829 [Patch] Patch for setting parent page via REST API
113, #14740 [Patch] display decimals hours only if fractional
114, #14735 [Patch] Allow negative time entries
115, #14679 [Patch] Hierarchical relationships of parent and son issues in roadmap viewer
116, #14593 [Patch] migrate_from_trac.rake, print out validation errors when doing save
117, #14567 [Patch] migrate_from_trac.rake does not convert timestamps in Trac database version 23
118, #14527 [Patch] Git-smart-http authentication by repository
119, #14509 [Patch] Add view hook to associated revision partial
120, #14451 [Patch] Icons for issue and gantt export
121, #14438 [Patch] Different identifier between repository and redmine project
122, #14148 [Patch] Double translation: label_f_hours vs. x_hours
123, #14109 [Patch] Issue REST API  should return visible changesets from other projects
124, #14039 [Patch] Display parent issue description on subissue
125, #13927 [Patch] Reduce coupling between plugins and the "plugins/" directory
126, #13888 [Patch] Fix message-id mail header to be invariant respect  daylight savings
127, #13763 [Patch] Live check of hostname setting
128, #13747 [Patch] Issue Colors Patch for #4967
129, #13696 [Patch] Projects admin, show issues count
130, #13688 [Patch] Chosen thumbnail has to be bigger than requested one and not smaller
131, #13665 [Patch] atom available on wiki page footer
132, #13658 [Patch] include "In-Reply-To" field to aid email threading for some clients
133, #13645 [Patch] Do not show context menu when right clicking on image.
134, #13612 [Patch] Members roles : display group of role
135, #13545 [Patch] Workflow permissions are broken if user has multiple roles in project
136, #13468 [Patch] News creation over REST
137, #13413 [Patch] Let users choose how many days in advance they want to receive issue due date reminders via email
138, #13407 [Patch] Update migrate_from_mantis.rake to migrate from Mantis 1.2.10 to Redmine
139, #13400 [Patch] Calculate %done based on estimated and logged time
140, #13359 [Patch] Better List-Id to help aid Gmail filtering
141, #13239 [Patch] migrate_from_mantis script doesn't work for later mantis versions
142, #13234 [Patch] Create a new wiki page link for laymans
143, #13068 [Patch] Allow plugins to generate test coverage reports on MRI 1.9
144, #13041 [Patch] Update last_login_on when authenticating with Redmine.pm
145, #12983 [Patch] "Only for things I watch or I'm involved in" sends notifications only for issues
146, #12937 [Patch] mail_handler patch
147, #12850 [Patch] User profile : Link to project in mail notifications by project selection
148, #12813 [Patch] Allow replies to original issue e-mail to add issue notes
149, #12746 [Patch] Add include=journals support to issues REST api
150, #12730 [Patch] Fix sorting and PDF output of Gantt diagram & start date calculation and grouping
151, #12664 [Patch] MyPage block for latest forum posts
152, #12659 [Patch] Broken dirty_tracking inside a after_save callback for the Issue model due to reload in Mailer
153, #12541 [Patch] Add icon class to items in issues contextual menu when appropiate
154, #12524 [Patch] Update issue - form position
155, #12338 [Patch] Allow MailHandler to submit to a specific issue
156, #12268 [Patch] Hook in mailer/issue_add views
157, #12032 [Patch] Collapsible Sidebar
158, #11898 [Patch] Inheritable issue categories
159, #11684 [Patch] Truncate incoming emails
160, #11500 [Patch] Add --unknown-user=register to create inactive users
161, #11499 [Patch] Fixed attachments handling when receiving a new issue by mail
162, #11497 [Patch] Dry up logging in MailHandler class
163, #11495 [Patch] Reopen closed issues on reply by email
164, #11493 [Patch] Show URL to attached file in plain text issue email
165, #11492 [Patch] Added :view_projects_index_activity_menu hook
166, #11120 [Patch] Order replies of messages boards based on user preference
167, #11064 [Patch] Trac -> Redmine wiki conversion : slashed links
168, #11057 [Patch] Confirm admin flag change on a separate page
169, #11022 [Patch] Link from diff to revision
170, #10970 [Patch] Sort issues in roadmap by IssueStatus.position
171, #10869 [Patch] Add Full PDF output to issue summary list
172, #10767 [Patch] Adding completed ratio support to log messages
173, #10628 [Patch] Generate issue export filename with project name
174, #10571 [Patch] Project identifiers missing in API output
175, #10509 [Patch] Add view_groups_form hook
176, #10456 [Patch] Add view_roles_form_upper_box hook
177, #9731 [Patch] Automate Mercurial Repository Creation
178, #9697 [Patch] Projects list with progress
179, #9579 [Patch] Redmine.pm: crediential cache expiration
180, #9563 [Patch] PATCH: Add per-tracker global cc for issue creation and update notifications
181, #9359 [Patch] invert project <-> repository relationship
182, #9319 [Patch] Prevent passing :label option to HTML tag in TabularFormBuilder
183, #9317 [Patch] Admin users should be always authorized when no context is given
184, #9281 [Patch] easy logging of usernames in apache access logs via custom response header
185, #9181 [Patch] Enhance migrate_from_trac.rake in order to import Trac 'found in version' Field
186, #9102 [Patch] Dry up MailHandler logging
187, #9096 [Patch] Fix redirection to non-latin wiki pages after logon
188, #9066 [Patch] Redmine.pm not working for merges/copy #3727
189, #9022 [Patch] Preserve leading zeros in #nnn issue links
190, #8934 [Patch] Add support for annotate with subversion when username contain space
191, #8831 [Patch] CSS class for issues due today in the issue list
192, #8768 [Patch] Edit comments for a certain time
193, #8757 [Patch] Add hook for bulk edit post-save state
194, #8588 [Patch] Rakefile for rake 0.9.2
195, #8451 [Patch] API:REST patch for the Net::Redmine::API::REST Perl Module
196, #8383 [Patch] Display subprojects as individual unordered list items on project overview
197, #8332 [Patch] Hook for project_settings_tab
198, #8301 [Patch] queries/_filters.rhtml inefficient.
199, #8294 [Patch] Include repos in scheduled fetch
200, #8257 [Patch] Proposal for supporting project-specific wildcard addresses in default mail handler
201, #8254 [Patch] Add previous/next functionality in diffs
202, #8222 [Patch] Setting model should use Rails.cache instead of class variable
203, #8196 [Patch] Adding a project param to perl auth module
204, #8109 [Patch] Support for global permissions in acts_as_attachable
205, #7976 [Patch] Hooks for adding content to the bottom of news
206, #7975 [Patch] Hook for adding content to the side bar of Wiki page 
207, #7974 [Patch] Hook for adding content to the bottom of Wiki page
208, #7959 [Patch] Patch for repository revision update (reload)
209, #7895 [Patch] Git, Mercurial: Allow source links using a tag in addition to revision hashes
210, #7829 [Patch] Show branches changsets belongs to on issue page
211, #7770 [Patch] use unless in control structures where it improves readability
212, #7701 [Patch] Updated Project/Index to appear more like Admin/Projects
213, #7664 [Patch] Allowing plugins to add an option for the default gravatar
214, #7637 [Patch] Display edit form above History in reverse chronological order
215, #7610 [Patch] Patch providing issue journal rollback
216, #7578 [Patch] Patch: migrate ticket's owner changes when importing from Trac
217, #7574 [Patch] RSS autodiscovery for wiki pages
218, #7570 [Patch] Change test_helper requirement in tests
219, #7528 [Patch] Fetch small initial set of repository changesets
220, #7456 [Patch] Gantt filters
221, #7447 [Patch] Patch for improved move/copy
222, #7304 [Patch] expand the size of date field
223, #7204 [Patch] Caching of public pages, requested from anonymous users (10x - 20x speed improvements)
224, #7190 [Patch] Timelog: Show date range filter in one line and move tabs to a dedicated partial
225, #7086 [Patch] Few fixes for subversion
226, #7058 [Patch] Duplicate submit and link buttons on top of the edit form.
227, #6967 [Patch] Revision Diff Link rendered as text
228, #6926 [Patch] Plugins captions for name and descriptions has not i18n support
229, #6864 [Patch] Support of mail notification for changesets
230, #6807 [Patch] internal hostname included in back_url
231, #6778 [Patch] Wiki compatibility link broken w/o project_id
232, #6722 [Patch] Add a summary to projects
233, #6690 [Patch] Redmine link to user profile
234, #6649 [Patch] Tooltip for icons
235, #6528 [Patch] Hooks for Administration -> Settings
236, #6475 [Patch] Add an option to set the project name from apache when authenticating with Redmine.pm
237, #6469 [Patch] "Activity" doesn't work with oracle database
238, #6450 [Patch] Allow localized date input and correctly transform for custom date fields
239, #6440 [Patch] Support for wiki page rendering in my page
240, #6431 [Patch] Allow parent task field to be used in filters
241, #6414 [Patch] Added FLAG to Redmine.pm to AllowAlternateAuth methods on apache
242, #6357 [Patch] Show and sort by due_date in reminders
243, #6330 [Patch] Hyperlinks with "%" or "!" at the end
244, #6247 [Patch] Display terget version in mouse-over popup for issues in Gantt
245, #6177 [Patch] "bignum too big to convert into `long'" in migrate_from_trac.rake
246, #6159 [Patch] Subversion: latest changesets performance improvement.
247, #6107 [Patch] Modify reposman.rb to delete a project on the repository when this project has been deleted on redmine
248, #6096 [Patch] Highlighting Skype links in wiki
249, #6053 [Patch] Fixed issue list context menu overflow
250, #5966 [Patch] change to allow openID to use Google Apps
251, #5957 [Patch] Export all users' information
252, #5919 [Patch] Wiki looks trying to strip macro args but no effect
253, #5899 [Patch] Display user's gravatar when editing profile
254, #5897 [Patch] Use issue/forum title in URLs for search engine optimization
255, #5893 [Patch] Filter Options: Allow to filter for description and notes
256, #5891 [Patch] New IssuesController hook for new issues
257, #5838 [Patch] add call to :view_repositories_show_contextual hook in app/views/repositories/revision.rhtml
258, #5829 [Patch] show roadmap with child project issues.
259, #5790 [Patch] Save year_from and month_from in the ganttchart
260, #5764 [Patch] migrate_from_trac does not support trac 0.12
261, #5722 [Patch] Custom Boolean Fields cannot be set to true
262, #5690 [Patch] Change LDAP password
263, #5669 [Patch] Subversion mirror creation.
264, #5668 [Patch] Invite Feature for projects
265, #5556 [Patch] Display more projects in project jump box
266, #5554 [Patch] Make links to various redmine objects more consistent
267, #5535 [Patch] Assigned to issuelist filter: added  value
268, #5530 [Patch] Additional hooks on top of the issue new/edit/bulk edit views
269, #5510 [Patch] Enable Mutliple Versions Per Issue
270, #5447 [Patch] User status can not be changed with javascript  disabled
271, #5389 [Patch] Option redirect_to in UsersController#edit when a params :back is defined
272, #5268 [Patch] Handle commas in returned OpenID fullnames
273, #5267 [Patch] Allow for OpenID-only operation
274, #5249 [Patch] rel=nofollow on external links
275, #5201 [Patch] Description field for Tracker setting.
276, #5200 [Patch] Redmine.pm - LDAP Host as URI
277, #5119 [Patch] "User group" custom field
278, #5068 [Patch] add link to Users on Member page.
279, #5065 [Patch] Importing wiki with different encoding
280, #5035 [Patch] Migrate from trac - Errors in wiki formating
281, #5027 [Patch] hook in the mail_handler
282, #4979 [Patch] Human readable Time for the issue table
283, #4977 [Patch] LDAP user cant change username and email
284, #4975 [Patch] Add feature to automatically archive old projects
285, #4964 [Patch] Change sorting order globally
286, #4878 [Patch] More Hook Features
287, #4822 [Patch] Version cannot be added from issue without existing versions
288, #4755 [Patch] Create and maintain groups from LDAP attributes
289, #4705 [Patch] Allow selection of up to five fields in timelog report
290, #4665 [Patch] Projects not calling EnabledModule callbacks in some cases
291, #4662 [Patch] Handled-mail should use set issue.assigned_to to the first "To" address
292, #4641 [Patch] Add information about openid requirements to /admin/info
293, #4635 [Patch] Filter by Role clause
294, #4580 [Patch] Run rake db:schema:dump after rake db:migrate_plugins
295, #4571 [Patch] Allow labels for Redmine links
296, #4548 [Patch] please pull in debian branch
297, #4535 [Patch] Import Target Version from Mantis
298, #4520 [Patch] Simplify URL Matching in Redmine
299, #4502 [Patch] Query date filters by months (prev, this, next)
300, #4277 [Patch] Add "hide prefixed projectname from issuesubject on issuelist" setting
301, #4262 [Patch] Bazaar: correct renames handling, other improvements
302, #4113 [Patch] Directory listing with CVS v1.11 patch
303, #4071 [Patch] Accept more input when replying to a ticket using e-mail
304, #4029 [Patch] Deletion of redmine-project should delete svn-project, too
305, #3971 [Patch] Add new notification abitily.
306, #3901 [Patch] Make length of short project description customizable
307, #3827 [Patch] Allow (SVN) repository browsing in Redmine.pm
308, #3806 [Patch] Template engine
309, #3803 [Patch] Show custom user fields in csv export of time entry reports
310, #3770 [Patch] text/html documents force currently firefox to open download dialog
311, #3756 [Patch] Integer custom fields should use correct query controls
312, #3754 [Patch] add some additional URL paths to robots.txt
313, #3749 [Patch] Wiki. TOC. The standardised anchors and admissible "fragment" part of URI.
314, #3732 [Patch] Incoming mail IMAP : Notify when an error occurs
315, #3712 [Patch] enhanced mod_perl module for apache
316, #3608 [Patch] migrate_from_mantis encoding patch
317, #3606 [Patch] Copy queries
318, #3586 [Patch] Add an option to filter issues by people who were assigned to it in the past
319, #3477 [Patch] Fix access handler to remove the need for a separate svn-private/git-private
320, #3437 [Patch] Textile parser regression with !! url
321, #3394 [Patch] stripping comments prevents importing Trac compatible subversion messages
322, #3358 [Patch] Advanced LDAP authentication
323, #3357 [Patch] Revision log relative to current location in the Repository Browser
324, #3274 [Patch] Wiki Page Categories
325, #3245 [Patch] Roadmap - show Estimated Time and Spent Time
326, #3195 [Patch] issue's start date could be the latest due date of predecessors
327, #3123 [Patch] Check additional mail headers when creating issues via email
328, #3117 [Patch] Add the possibility to select the comment field to /timelog/report
329, #3052 [Patch] Patch for Redmine to persist form state when adding multiple issues
330, #2931 [Patch] Templating for description of new tickets by Tracker
331, #2928 [Patch] new migration script for scarab2redmine
332, #2862 [Patch] Make user sorting by his localized encoding name instead of utf-8 encoding name 
333, #2750 [Patch] Project tinyurl
334, #2748 [Patch] Improved Trac-Importer with subversion repository migration
335, #2746 [Patch] Send out issue priority in the email notification header
336, #2696 [Patch] Add subcategory to category
337, #2685 [Patch] Display notice when commenting on closed tickets
338, #2641 [Patch] other-formats paragraph location is inconsistent
339, #2635 [Patch] Display notice on forum thread or reply creation
340, #2631 [Patch] Add breadcrumbs to news pages
341, #2576 [Patch] Partially decouple application_helper.rb from Gravatar
342, #2525 [Patch] Redmine management of Git repositories
343, #2510 [Patch] [SCM, Bazaar] Prefer revision's "author" field over "committer" if available
344, #2504 [Patch] Importing Trac "Ticket keywords"
345, #2459 [Patch] Links and filters for project and author in activity and search pages
346, #2457 [Patch] Different style of new issue/timelog interface
347, #2281 [Patch] Total-columns in the issue summary (issue_report)
348, #2198 [Patch] print short list of users in overview page of project
349, #2197 [Patch] protect user email from spmamer
350, #2195 [Patch] wiki marco to link to files
351, #2173 [Patch] Update the Git repository automatically
352, #2114 [Patch] Fixed Bugs in Importer Area
353, #2106 [Patch] Ability to choose period in 'Spent time' and count of watched issues on 'My page'.
354, #2054 [Patch] Trac Tables are not converted into Redmine
355, #2016 [Patch] Tracker Moves of an Issue should create an entry in the activity
356, #2013 [Patch] Skip notification of issue's updating.
357, #1857 [Patch] Make {{toc}} render as properly nested list + skip support
358, #1783 [Patch] automatic repository creation
359, #1764 [Patch] Add session_config option-stubs to environment-config
360, #1705 [Patch] Use Rails timezones support
361, #1700 [Patch] Support for extra macros to help in move from trac
362, #1680 [Patch] Make version description multiline and textilizable
363, #1671 [Patch] Show a breakdown of estimated/spent/remaining time for a version
364, #1667 [Patch] Default tracker setting
365, #1651 [Patch] Hack to make redmine use pygmentize instead of CodeRay
366, #1650 [Patch] Start/end time tracking for timelogging
367, #1616 [Patch] Allow email to create and reply to forum messages
368, #1601 [Patch] Make second level navigation for all views in repository controller
369, #1587 [Patch] Simple Phone Number and Address List for Users
370, #1568 [Patch] Added Support for htpasswd authentication
371, #1486 [Patch] Highlight recent forum activity
372, #1476 [Patch] Ignore whitespace when using SVN (requires installation of gnu diff)
373, #1475 [Patch] Sort by subproject then by subject in issue tracker
374, #1472 [Patch] Organized All Projects List View
375, #1470 [Patch] Projects Info Block for MyPage
376, #1446 [Patch] Allow notification on editing of a message
377, #1382 [Patch] Add a global notification cc 
378, #1333 [Patch] Patch for membership activity (#1195)
379, #1260 [Patch] Add SCM:Visual SourceSafe patch
380, #1081 [Patch] Add Activity block to My Page
381, #1059 [Patch] Fully integrates svn/dav apache authentication
382, #1021 [Patch] Patch for #1013 (uniqueness-validation of custom query name within user-scope)
383, #1008 [Patch] redmine:migrate_from_trac doesn't work when multibyte characters are used in trac.
384, #989 [Patch] Migration task from Bugzilla
385, #987 [Patch] Create relation for new issue
386, #811 [Patch] Username validation - allow spaces...
387, #691 [Patch] Add column totals to Issus Summary Report
388, #684 [Patch] Add journal count on issues list
389, #640 [Patch] When choosing assignee, automatically switch status to Assigned
390, #258 [Patch] Textilize document snippet on overview and activity page
391, #257 [Patch] Optional project repository creation when using reposman.rb
392, #251 [Patch] Patch for Feature Request #9785 (Default issues due date == assigned target version date)
393, #247 [Patch] Notification mail sender is the author and includes project information.
394, #244 [Patch] auto wiki preview
395, #240 [Patch] views/user/edit, make password fields not-autocomplete (UI fix)
396, #239 [Patch] Adds two blocks for my/page and fixes a report bug
397, #233 [Patch] Per project themes patch
398, #232 [Patch] SCM URL/ROOT Information on Repository Page
399, #230 [Patch] hides some issues in calendar block in My Page
400, #219 [Patch] Issues fixed in multiple versions
401, #212 [Patch] Assign To limited by workflow
/Users/tomi/.pyenv/versions/3.5.2/lib/python3.5/unittest/case.py:600: ResourceWarning: unclosed 
  testMethod()
.
----------------------------------------------------------------------
Ran 1 test in 9.330s

OK

Process finished with exit code 0

(OK) the result only contains tickets whose tracker_id is "Patch"

@coveralls

This comment has been minimized.

coveralls commented Apr 15, 2017

Coverage Status

Changes Unknown when pulling d726748 on niwatolli3:fix-next-issue-filter into ** on maxtepkeev:master**.

@niwatolli3

This comment has been minimized.

Contributor

niwatolli3 commented Apr 17, 2017

Hi, Max-san.
Could you check it up?

@maxtepkeev maxtepkeev self-assigned this Apr 18, 2017

@maxtepkeev maxtepkeev added the bug label Apr 18, 2017

bulk_params.append({'offset': offset, 'limit': limit})
bulk_param = dict(params)
bulk_param.update({'offset': offset, 'limit': limit})
bulk_params.append(bulk_param)

This comment has been minimized.

@maxtepkeev

maxtepkeev Apr 18, 2017

Owner

Can be rewritten as bulk_params.append(dict(params, **{'offset': offset, 'limit': limit}))

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Apr 18, 2017

Hi @niwatolli3

Apologies for the delay with an answer.

Thanks for identifying this bug and fixing it.

Can I ask you, please, to remove the tests/test_over100.py file from the pull request and write a small unit test that reproduces the bug instead or just remove the file and leave writing unit test to me, that is also fine. I also left a comment in the code about the changes that should be made. After you make them, please squash all the commits into one and I will happily merge this pull request.

fix over 100 tickets problem in issue.filter
fix over 100 tickets problem

@niwatolli3 niwatolli3 force-pushed the niwatolli3:fix-next-issue-filter branch from d726748 to f85ee06 Apr 19, 2017

@niwatolli3

This comment has been minimized.

Contributor

niwatolli3 commented Apr 19, 2017

Dear Max-san,

Thank you for your comment.

just remove the file and leave writing unit test to me, that is also fine.
Thanks. I removed unit test, cuz I can't find out how to add the unit test.
Please review it.

@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling f85ee06 on niwatolli3:fix-next-issue-filter into ** on maxtepkeev:master**.

3 similar comments
@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling f85ee06 on niwatolli3:fix-next-issue-filter into ** on maxtepkeev:master**.

@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling f85ee06 on niwatolli3:fix-next-issue-filter into ** on maxtepkeev:master**.

@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Changes Unknown when pulling f85ee06 on niwatolli3:fix-next-issue-filter into ** on maxtepkeev:master**.

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Apr 19, 2017

@niwatolli3 Perfect, thank you. I will try to write a unit test for this and release a new version with your fix ASAP.

@maxtepkeev maxtepkeev merged commit 6fcf653 into maxtepkeev:master Apr 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 98.391%
Details
@niwatolli3

This comment has been minimized.

Contributor

niwatolli3 commented Apr 19, 2017

Thanks, Max-san! 💯

maxtepkeev added a commit that referenced this pull request Apr 19, 2017

maxtepkeev added a commit that referenced this pull request Apr 19, 2017

@maxtepkeev

This comment has been minimized.

Owner

maxtepkeev commented Apr 19, 2017

@niwatolli3 v2.0.2 is available on PyPI

@niwatolli3

This comment has been minimized.

Contributor

niwatolli3 commented Apr 20, 2017

@maxtepkeev Thank you for your quick release 👍
I confirmed that the bug is fixed.

@niwatolli3 niwatolli3 deleted the niwatolli3:fix-next-issue-filter branch Apr 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment