Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support status code 204 #189

Merged
merged 1 commit into from Dec 8, 2017
Merged

support status code 204 #189

merged 1 commit into from Dec 8, 2017

Conversation

@dotSlashLu
Copy link
Contributor

@dotSlashLu dotSlashLu commented Dec 7, 2017

I've seen status 204 (No content) returning from our Redmine 3.3.0.stable when a project was successfully deleted by redmine.project.delete().

Zhang Qiang
@coveralls
Copy link

@coveralls coveralls commented Dec 7, 2017

Coverage Status

Changes Unknown when pulling 01c04c5 on dotSlashLu:master into ** on maxtepkeev:master**.

@dotSlashLu
Copy link
Contributor Author

@dotSlashLu dotSlashLu commented Dec 8, 2017

I checked Redmine's code, there are no sign why I got a 204. But I did find something related to this: Updating a version through rest API returns invalid JSON

I think maybe I'm using a modified version of Redmine. Anyway, a status of 204 is perfectly valid in such a situation in my opinion, since the project no longer exists. I think maybe we should loose the status code validation, it seems no harm to me to consider all 2xx codes as valid and successful return values.

@maxtepkeev
Copy link
Owner

@maxtepkeev maxtepkeev commented Dec 8, 2017

Thanks for the PR. I don't think that adding all the remaining 2xx codes makes sense for now, but adding a 204 is definitely a good idea.

@maxtepkeev maxtepkeev merged commit fc224f7 into maxtepkeev:master Dec 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 98.391%
Details
@maxtepkeev maxtepkeev self-requested a review Dec 8, 2017
maxtepkeev added a commit that referenced this pull request Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.