Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix send_information for user creation and update #227

Closed
wants to merge 1 commit into from

Conversation

wodny
Copy link

@wodny wodny commented Jul 11, 2019

Before this change send_information field was included in the User
structure but all versions of Redmine expect it at the highest level of
the request params structure (see app/controllers/users_controller.rb).
Because of that account information emails were never sent.

Before this change send_information field was included in the User
structure but all versions of Redmine expect it at the highest level of
the request params structure (see app/controllers/users_controller.rb).
Because of that account information emails were never sent.
@coveralls
Copy link

@coveralls coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.01%) to 98.618% when pulling 53a0a77 on wodny:fix-send-information into 5769a92 on maxtepkeev:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.01%) to 98.618% when pulling 53a0a77 on wodny:fix-send-information into 5769a92 on maxtepkeev:master.

@maxtepkeev maxtepkeev self-assigned this Aug 18, 2019
maxtepkeev added a commit that referenced this issue May 20, 2020
@maxtepkeev
Copy link
Owner

@maxtepkeev maxtepkeev commented May 20, 2020

Hi,

Thanks for raising this issue and apologize that it took me so long to respond.

Unfortunately I can't accept this PR because it doesn't have any tests, also I don't agree that merging _prepare_create_request and _prepare_update_request is a good idea and I don't think that we should introduce noncontainer attributes because this is a corner case and there're no other attributes at the moment (and hopefully never will) which require this functionality to be implemented.

So I've fixed this a little bit differently in 8a7b116. Anyway thanks for reporting this bug.

@maxtepkeev maxtepkeev closed this May 20, 2020
avgas3 pushed a commit to avgas3/python-redmine that referenced this issue Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants