Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

request to include tests in gem #6

Closed
pravi opened this Issue · 9 comments

3 participants

@pravi

Can we include the tests as part of the gem itself (many gems include tests)? I'm packaging this library for debian and I have to take a github tarball instead of the gem.

@maxwell
Owner
@pravi

So test/test_rack_piwik.rb doesn't do anything? I get all tests passed when it is run.

Running tests for ruby1.8 using debian/ruby-tests.rb...
Loaded suite debian/ruby-tests
Started
....

Finished in 0.209267 seconds.

4 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

19.11 tests/s, 43.01 assertions/s
/usr/bin/ruby1.9.1 -I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
Running tests for ruby1.9.1 using debian/ruby-tests.rb...
Loaded suite debian/ruby-tests
Started
....

Finished in 0.027211421 seconds.

4 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

147.00 tests/s, 330.74 assertions/s

@GSI
Collaborator
GSI commented

The plugin does have tests - we corrected & added some in May 2012 (see history).

@maxwell
Owner

whoops my bad. I think I completely misunderstood the question altogether....

Were you asking for permission to include the tests in the tarball? I assume they should have the same licence as the gem itself.

or where you asking if there were external tests somewhere else that you wanted to pull in and include?

@pravi
@GSI
Collaborator

@maxwell Can you give me publishing rights on the according RubyGems.org gem? How can I hand you my email address for doing so?

@maxwell
Owner

i guess just email me: maxwell@joindiaspora.com

@GSI
Collaborator

@pravi From version 0.2.1 on the gem includes the tests as well (see https://rubygems.org/gems/rack-piwik/versions/0.2.1). Thanks for packaging it up for Debian!

@GSI GSI closed this
@pravi

@GSI thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.