request to include tests in gem #6

Closed
pravi opened this Issue Mar 5, 2013 · 9 comments

Projects

None yet

3 participants

@pravi
pravi commented Mar 5, 2013

Can we include the tests as part of the gem itself (many gems include tests)? I'm packaging this library for debian and I have to take a github tarball instead of the gem.

@maxwell
Owner
maxwell commented Mar 5, 2013

There are no tests for this gem. :)

  • Maxwell

On Mar 5, 2013, at 5:31 AM, Praveen Arimbrathodiyil <
notifications@github.com> wrote:

Can we include the tests as part of the gem itself (many gems include
tests)? I'm packaging this library for debian and I have to take a github
tarball instead of the gem.


Reply to this email directly or view it on
GitHubhttps://github.com/maxwell/rack-piwik/issues/6
.

@pravi
pravi commented Mar 6, 2013

So test/test_rack_piwik.rb doesn't do anything? I get all tests passed when it is run.

Running tests for ruby1.8 using debian/ruby-tests.rb...
Loaded suite debian/ruby-tests
Started
....

Finished in 0.209267 seconds.

4 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

19.11 tests/s, 43.01 assertions/s
/usr/bin/ruby1.9.1 -I/usr/lib/ruby/vendor_ruby /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb
Running tests for ruby1.9.1 using debian/ruby-tests.rb...
Loaded suite debian/ruby-tests
Started
....

Finished in 0.027211421 seconds.

4 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

147.00 tests/s, 330.74 assertions/s

@GSI
Collaborator
GSI commented Mar 6, 2013

The plugin does have tests - we corrected & added some in May 2012 (see history).

@maxwell
Owner
maxwell commented Mar 6, 2013

whoops my bad. I think I completely misunderstood the question altogether....

Were you asking for permission to include the tests in the tarball? I assume they should have the same licence as the gem itself.

or where you asking if there were external tests somewhere else that you wanted to pull in and include?

@pravi
pravi commented Mar 6, 2013

The tarball from github has tests, but the gem file at rubygems.org does
not have it. Can you include the tests as part of the gem?

@GSI
Collaborator
GSI commented Mar 18, 2013

@maxwell Can you give me publishing rights on the according RubyGems.org gem? How can I hand you my email address for doing so?

@maxwell
Owner
maxwell commented Mar 18, 2013

i guess just email me: maxwell@joindiaspora.com

@GSI
Collaborator
GSI commented Mar 18, 2013

@pravi From version 0.2.1 on the gem includes the tests as well (see https://rubygems.org/gems/rack-piwik/versions/0.2.1). Thanks for packaging it up for Debian!

@GSI GSI closed this Mar 18, 2013
@pravi
pravi commented Mar 18, 2013

@GSI thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment