-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing currency on new profile page caused fatal error #564
Comments
@giubaru yes, good catch, this is definitely a bug. The job removal was intended, but leaving the call to it was not. |
@karanj the bug itself is fixed now. We're still pretty early with the multi-currency implementation, so if you change your family setting to Edit/delete functionality is not in the UI yet for this, so your best bet is a direct DB change for now. That functionality will be in soon though! |
@zachgoll thanks for the speedy resolution, I'll check it out. for what it's worth - I had created two accounts which I'd already marked as AUD. So it was rather that I was updating my default; conversion was not intended. |
Since my base currency is AUD, I went to the settings page to change it to AUD after creating a couple of sample accounts and realising I had to select AUD every time. Whole thing bailed on me - here's the error stack:
NameError in SettingsController#update
Rails.root: /workspace
Request
Parameters:
NameError in SettingsController#update uninitialized constant SettingsController::ConvertCurrencyJob Extracted source (around line #17):15
16
17
18
19
20
Rails.root: /workspace
Application Trace | Framework Trace | Full Trace
app/controllers/settings_controller.rb:17:in
update' rails (5411787a155e) actionpack/lib/action_controller/metal/basic_implicit_render.rb:8:in
send_action'rails (5411787a155e) actionpack/lib/abstract_controller/base.rb:226:in
process_action' rails (5411787a155e) actionpack/lib/action_controller/metal/rendering.rb:193:in
process_action'rails (5411787a155e) actionpack/lib/abstract_controller/callbacks.rb:261:in
block in process_action' rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:121:in
block in run_callbacks'turbo-rails (2.0.5) lib/turbo-rails.rb:24:in
with_request_id' turbo-rails (2.0.5) app/controllers/concerns/turbo/request_id_tracking.rb:10:in
turbo_tracking_request_id'rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:130:in
block in run_callbacks' rails (5411787a155e) actiontext/lib/action_text/rendering.rb:25:in
with_renderer'rails (5411787a155e) actiontext/lib/action_text/engine.rb:71:in
block (4 levels) in <class:Engine>' rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:130:in
instance_exec'rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:130:in
block in run_callbacks' rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:141:in
run_callbacks'rails (5411787a155e) actionpack/lib/abstract_controller/callbacks.rb:260:in
process_action' rails (5411787a155e) actionpack/lib/action_controller/metal/rescue.rb:27:in
process_action'rails (5411787a155e) actionpack/lib/action_controller/metal/instrumentation.rb:77:in
block in process_action' rails (5411787a155e) activesupport/lib/active_support/notifications.rb:210:in
block in instrument'rails (5411787a155e) activesupport/lib/active_support/notifications/instrumenter.rb:58:in
instrument' rails (5411787a155e) activesupport/lib/active_support/notifications.rb:210:in
instrument'rails (5411787a155e) actionpack/lib/action_controller/metal/instrumentation.rb:76:in
process_action' rails (5411787a155e) actionpack/lib/action_controller/metal/params_wrapper.rb:259:in
process_action'rails (5411787a155e) activerecord/lib/active_record/railties/controller_runtime.rb:32:in
process_action' rails (5411787a155e) actionpack/lib/abstract_controller/base.rb:163:in
process'rails (5411787a155e) actionview/lib/action_view/rendering.rb:40:in
process' rails (5411787a155e) actionpack/lib/action_controller/metal.rb:227:in
dispatch'rails (5411787a155e) actionpack/lib/action_controller/metal.rb:310:in
dispatch' rails (5411787a155e) actionpack/lib/action_dispatch/routing/route_set.rb:50:in
dispatch'rails (5411787a155e) actionpack/lib/action_dispatch/routing/route_set.rb:33:in
serve' rails (5411787a155e) actionpack/lib/action_dispatch/journey/router.rb:53:in
block in serve'rails (5411787a155e) actionpack/lib/action_dispatch/journey/router.rb:133:in
block in find_routes' rails (5411787a155e) actionpack/lib/action_dispatch/journey/router.rb:126:in
each'rails (5411787a155e) actionpack/lib/action_dispatch/journey/router.rb:126:in
find_routes' rails (5411787a155e) actionpack/lib/action_dispatch/journey/router.rb:34:in
serve'rails (5411787a155e) actionpack/lib/action_dispatch/routing/route_set.rb:879:in
call' rack (3.0.9.1) lib/rack/tempfile_reaper.rb:20:in
call'rack (3.0.9.1) lib/rack/etag.rb:29:in
call' rack (3.0.9.1) lib/rack/conditional_get.rb:43:in
call'rack (3.0.9.1) lib/rack/head.rb:15:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/http/permissions_policy.rb:38:in
call'rails (5411787a155e) actionpack/lib/action_dispatch/http/content_security_policy.rb:36:in
call' rack-session (2.0.0) lib/rack/session/abstract/id.rb:272:in
context'rack-session (2.0.0) lib/rack/session/abstract/id.rb:266:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/cookies.rb:704:in
call'rails (5411787a155e) activerecord/lib/active_record/migration.rb:674:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/callbacks.rb:31:in
block in call'rails (5411787a155e) activesupport/lib/active_support/callbacks.rb:101:in
run_callbacks' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/callbacks.rb:30:in
call'rails (5411787a155e) actionpack/lib/action_dispatch/middleware/executor.rb:16:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in
call'rails (5411787a155e) actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:31:in
call' web-console (4.2.1) lib/web_console/middleware.rb:132:in
call_app'web-console (4.2.1) lib/web_console/middleware.rb:19:in
block in call' web-console (4.2.1) lib/web_console/middleware.rb:17:in
catch'web-console (4.2.1) lib/web_console/middleware.rb:17:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/show_exceptions.rb:32:in
call'rails (5411787a155e) railties/lib/rails/rack/logger.rb:41:in
call_app' rails (5411787a155e) railties/lib/rails/rack/logger.rb:29:in
call'rails (5411787a155e) actionpack/lib/action_dispatch/middleware/remote_ip.rb:96:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/request_id.rb:33:in
call'rack (3.0.9.1) lib/rack/method_override.rb:28:in
call' rack (3.0.9.1) lib/rack/runtime.rb:24:in
call'rails (5411787a155e) activesupport/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/server_timing.rb:61:in
block in call'rails (5411787a155e) actionpack/lib/action_dispatch/middleware/server_timing.rb:26:in
collect_events' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/server_timing.rb:60:in
call'rails (5411787a155e) actionpack/lib/action_dispatch/middleware/executor.rb:16:in
call' rails (5411787a155e) actionpack/lib/action_dispatch/middleware/static.rb:27:in
call'rack (3.0.9.1) lib/rack/sendfile.rb:114:in
call' rails (5411787a155e) railties/lib/rails/engine.rb:536:in
call'puma (6.4.2) lib/puma/configuration.rb:272:in
call' puma (6.4.2) lib/puma/request.rb:100:in
block in handle_request'puma (6.4.2) lib/puma/thread_pool.rb:378:in
with_force_shutdown' puma (6.4.2) lib/puma/request.rb:99:in
handle_request'puma (6.4.2) lib/puma/server.rb:464:in
process_client' puma (6.4.2) lib/puma/server.rb:245:in
block in run'puma (6.4.2) lib/puma/thread_pool.rb:155:in `block in spawn_thread'
Request
Parameters:
{"_method"=>"patch",
"authenticity_token"=>"[FILTERED]",
"user"=>{"family_attributes"=>{"name"=>"J", "currency"=>"AUD"}, "first_name"=>"Karan", "last_name"=>"", "email"=>"[FILTERED]", "password"=>"[FILTERED]", "password_confirmation"=>"[FILTERED]"}}
The text was updated successfully, but these errors were encountered: