New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #13
Refactoring #13
Conversation
mazelka
commented
Jul 11, 2019
- fix Gemfile
- fix routes
- move Author destroy method o active admin
- move Books sorting to BooksSorting service
- add sorting for popular books by reviews_count
@orders = current_customer.orders.canceled | ||
@active_sorting = t('orders.index.canceled') | ||
render 'index' | ||
@orders_sorting = params[:sorting] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be extracted to service like OrdersFilter
app/assets/javascripts/address.js
Outdated
$(document).ready(function() { | ||
$(".submit-address").submit(function(e) { | ||
if ($('[name="billing"]').prop("checked")) { | ||
console.log(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 виу-виу
@@ -21,6 +22,7 @@ def update | |||
cart_details | |||
case step | |||
when :address | |||
binding.pry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨