Permalink
Switch branches/tags
Commits on May 16, 2016
  1. RELEASE-NOTES: synced with 2dcb5ad

    bagder committed May 16, 2016
  2. ftp: fix incorrect out-of-memory code in Curl_pretransfer

    - Return value type must match function type.
    
    s/CURLM_OUT_OF_MEMORY/CURLE_OUT_OF_MEMORY/
    
    Caught by Travis CI
    jay committed May 16, 2016
Commits on May 14, 2016
  1. ftp wildcard: segfault due to init only in multi_perform

    The proper FTP wildcard init is now more properly done in Curl_pretransfer()
    and the corresponding cleanup in Curl_close().
    
    The previous place of init/cleanup code made the internal pointer to be NULL
    when this feature was used with the multi_socket() API, as it was made within
    the curl_multi_perform() function.
    
    Reported-by: Jonathan Cardoso Machado
    Fixes #800
    bagder committed May 14, 2016
Commits on May 13, 2016
  1. libcurl-tlibcurl-thread: Update OpenSSL links

    Because the old OpenSSL link now redirects to their master documentation
    (currently 1.1.0), which does not document the required actions for
    OpenSSL <= 1.0.2.
    jay committed May 13, 2016
Commits on May 12, 2016
  1. RELEASE-NOTES: synced with 68701e5

    Added 8 bug fixes and 5 more contrbutors
    bagder committed May 12, 2016
  2. mprintf: Fix processing of width and prec args

    Prior to this change a width arg could be erroneously output, and also
    width and precision args could not be used together without crashing.
    
    "%0*d%s", 2, 9, "foo"
    
    Before: "092"
    After: "09foo"
    
    "%*.*s", 5, 2, "foo"
    
    Before: crash
    After: "   fo"
    
    Test 557 is updated to verify this and more
    jay committed with bagder Mar 9, 2016
  3. ConnectionExists: follow-up fix for proxy re-use

    Follow-up commit to 5823179
    
    Closes #648
    mkauf committed with bagder May 12, 2016
  4. darwinssl: fix certificate verification disable on OS X 10.8

    The new way of disabling certificate verification doesn't work on
    Mountain Lion (OS X 10.8) so we need to use the old way in that version
    too. I've tested this solution on versions 10.7.5, 10.8, 10.9, 10.10.2
    and 10.11.
    
    Closes #802
    PerMalmberg committed with bagder May 12, 2016
  5. http2: Add space between colon and header value

    curl's representation of HTTP/2 responses involves transforming the
    response to a format that is similar to HTTP/1.1. Prior to this change,
    curl would do this by separating header names and values with only a
    colon, without introducing a space after the colon.
    
    While this is technically a valid way to represent a HTTP/1.1 header
    block, it is much more common to see a space following the colon. This
    change introduces that space, to ensure that incautious tools are safely
    able to parse the header block.
    
    This also ensures that the difference between the HTTP/1.1 and HTTP/2
    response layout is as minimal as possible.
    
    Bug: curl#797
    
    Closes #798
    Fixes #797
    Lukasa committed with bagder May 11, 2016
  6. openssl: fix compile-time warning in Curl_ossl_check_cxn()

    ... introduced in curl-7_48_0-293-g2968c83:
    
    Error: COMPILER_WARNING:
    lib/vtls/openssl.c: scope_hint: In function ‘Curl_ossl_check_cxn’
    lib/vtls/openssl.c:767:15: warning: conversion to ‘int’ from ‘ssize_t’
    may alter its value [-Wconversion]
    kdudka committed May 12, 2016
  7. openssl: stricter connection check function

    - In the case of recv error, limit returning 'connection still in place'
    to EINPROGRESS, EAGAIN and EWOULDBLOCK.
    
    This is an improvement on the parent commit which changed the openssl
    connection check to use recv MSG_PEEK instead of SSL_peek.
    
    Ref: curl@856baf5#comments
    jay committed May 12, 2016
Commits on May 10, 2016
  1. TLS: SSL_peek is not a const operation

    Calling SSL_peek can cause bytes to be read from the raw socket which in
    turn can upset the select machinery that determines whether there's data
    available on the socket.
    
    Since Curl_ossl_check_cxn only tries to determine whether the socket is
    alive and doesn't actually need to see the bytes SSL_peek seems like
    the wrong function to call.
    
    We're able to occasionally reproduce a connect timeout due to this
    bug. What happens is that Curl doesn't know to call SSL_connect again
    after the peek happens since data is buffered in the SSL buffer and thus
    select won't fire for this socket.
    
    Closes #795
    Andersbakken committed with bagder May 10, 2016
Commits on May 9, 2016
  1. TLS: move the ALPN/NPN enable bits to the connection

    Only protocols that actually have a protocol registered for ALPN and NPN
    should try to get that negotiated in the TLS handshake. That is only
    HTTPS (well, http/1.1 and http/2) right now. Previously ALPN and NPN
    would wrongly be used in all handshakes if libcurl was built with it
    enabled.
    
    Reported-by: Jay Satiro
    
    Fixes #789
    bagder committed with jay May 9, 2016
Commits on May 8, 2016
  1. connect: fix invalid "Network is unreachable" errors

    Sometimes, in systems with both ipv4 and ipv6 addresses but where the
    network doesn't support ipv6, Curl_is_connected returns an error
    (intermittently) even if the ipv4 socket connects successfully.
    
    This happens because there's a for-loop that iterates on the sockets but
    the error variable is not resetted when the ipv4 is checked and is ok.
    
    This patch Fixes this problem by setting error to 0 when checking the
    second socket and not having a result yet.
    
    Fixes #794
    antlarr committed with bagder May 5, 2016
Commits on May 5, 2016
Commits on May 3, 2016
  1. connections: non-HTTP proxies on different ports aren't reused either

    Reported-by: Oleg Pudeyev and fuchaoqun
    
    Fixes #648
    bagder committed May 2, 2016
Commits on May 2, 2016
  1. http: make sure a blank header overrides accept_decoding

    Reported-by: rcanavan
    Assisted-by: Isaac Boukris
    Closes #785
    bagder committed May 2, 2016
Commits on May 1, 2016
  1. RELEASE-NOTES: synced with 7987f5c

    bagder committed May 1, 2016
  2. CURLOPT_ACCEPT_ENCODING.3: Follow-up clarification

    Mention possible content-length mismatch with sum of bytes reported
    by write callbacks when auto decoding is enabled.
    
    See #785
    frenche committed with bagder Apr 23, 2016
  3. tool_cb_hdr: Fix --remote-header-name with schemeless URL

    - Move the existing scheme check from tool_operate.
    
    In the case of --remote-header-name we want to parse Content-disposition
    for a filename, but only if the scheme is http or https. A recent
    adjustment 0dc4d8e was made to account for schemeless URLs however it's
    not 100% accurate. To remedy that I've moved the scheme check to the
    header callback, since at that point the library has already determined
    the scheme.
    
    Bug: curl#760
    Reported-by: Kai Noda
    jay committed May 1, 2016
  4. tls: make setting pinnedkey option fail if not supported

    to make it obvious to users trying to use the feature with TLS backends
    not supporting it.
    
    Discussed in #781
    Reported-by: Travis Burtrum
    bagder committed May 1, 2016
  5. nroff-scan.pl: verifies nroff pages

    ... not used by any test yet but can be used stand-alone.
    bagder committed May 1, 2016
  6. opts: fix broken/bad references

    bagder committed May 1, 2016