Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome timeout in Travis builds #10

Merged
merged 6 commits into from Jul 25, 2019

Conversation

@creazero
Copy link
Contributor

commented Jul 24, 2019

Turns out, Travis image has its own Chrome, which doesn't want to start for some reason. So I added a version guard for it (>= 75) and additional env vars from puppeteer's install.js.

Fixes #9
@ai

scripts/findChrome.js Outdated Show resolved Hide resolved
scripts/findChrome.js Outdated Show resolved Hide resolved
scripts/findChrome.js Show resolved Hide resolved
@ai

ai approved these changes Jul 24, 2019

@ai

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@mbalabash LGTM. We can release it under patch (as downloader fix) or minor (since we added new env variables) release.

@mbalabash

This comment has been minimized.

Copy link
Owner

commented Jul 25, 2019

Wow, awesome work!
Thanks you guys

@mbalabash mbalabash merged commit 7b46d13 into mbalabash:master Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.