Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☝ Version 1.0 #2

Closed
emagdalenaC2i opened this Issue Nov 30, 2018 · 32 comments

Comments

Projects
None yet
3 participants
@emagdalenaC2i
Copy link
Collaborator

emagdalenaC2i commented Nov 30, 2018

Here we can comment and define all the improvements to add in the version 1.0

Done

captura01

Notes

  • To reference another developer, use @
  • To reference another Issue or Pull Request use # or Username / Repository #
@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Nov 30, 2018

MIT license?? What do you think?

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Nov 30, 2018

You can add a license tab into Onshape (You have edit access)

@ula-w

This comment has been minimized.

Copy link
Collaborator

ula-w commented Nov 30, 2018

MIT licence is fine to us.

@ula-w

This comment has been minimized.

Copy link
Collaborator

ula-w commented Dec 4, 2018

We would like this feature not only to create weld connections but also to help constructor to choose weld type according to guidelines of production plant / welding technology.
User chooses where weld connections should be and shows thickness of welded plate, and he can choose from weld types which are feasible (for example square butt joint can be made for plate thickness 1-3mm, double square butt joint for plate thickness 2-5mm, V butt joint 3-20mm, U butt joint 15-40, so if plate thickness is 18mm user can choose from V butt joint and U butt joint not square butt joint; similar conditions are for inclined plates)
We would like this boundary conditions to be stored in csv file - we think it will be easier to adjust them for different companies. It would be great if we could have few of them in one custom feature, because there are different boundary conditions for different welding methods (user would choose method first).

@ula-w

This comment has been minimized.

Copy link
Collaborator

ula-w commented Dec 4, 2018

If you don't have access to boundary conditions and bevel dimensions I can prepare some based on these which we use.

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 4, 2018

@ula-w That's one of the reasons I add the settings tab in the feature.
The idea is that in the settings the user can select a csv or LookupTablePath with this boundary conditions.

Of course, @ula-w could you create a csv example?

@ula-w

This comment has been minimized.

Copy link
Collaborator

ula-w commented Dec 4, 2018

Something like that:
image

where:
image
angle in file is half of alpha = beta:
image
image
image

With putting this to feature script I will need some help. I know how to upload csv file to feature script, but I don't know how to look in there for right parameters.

@emagdalenaC2i emagdalenaC2i referenced this issue Dec 10, 2018

Open

☝ Version 2.0 #53

0 of 10 tasks complete
@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 11, 2018

@mbartlett21 I have created a Part Studio in the Onshape document https://cad.onshape.com/documents/7c7042b84e1ae5b391af796f/w/78d4b9bbae61ce42dadb481d/e/852e4c1dcebea967aa403527 with a few examples of butt welds
captura

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

@mbartlett21 I have imported the LICENSE in the Onshape document.
Do you need help with the creation of the PDF file?

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

When the pdf file is ready you can announce this FS in the Onshape forums

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

Can you please check the document before I put it in Onshape?
@emagdalenaC2i

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

ok, where is it?

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

Ok, I got it

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

@mbartlett21
Prerequisites:
Butt Welds: One or more edges to create the weld between

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

The rest is fine

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

Are you "Anonymous Unicorn"? 😄

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

Anonymous Unicorn??

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

Maybe... I handle with several google accounts. But I opened the file with my own user

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

That's what it says...

I have added the PDF to the Onshape document now, can you create a version?

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

@mbartlett21 I think it's better if we make a copy of the document and create a version, so it will not be all the previous versions (in development) available there.

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

I have shared the new document with you: https://cad.onshape.com/documents/f6dc5a7ab4bd8dcd6217ba88

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

ok, so you can create a version 1.0 and share it in the Onshape forums ;-)

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

@mbartlett21 Are you in Australia, right?

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

Yes

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

Can you do the forum release and @mention me, please?

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

The most part is your job, I left you the honor ... ;-)
As you prefer, do you want to publish it?

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

I'd still rather you publish it.
( You created almost all the butt weld profiles and you completed most of the issues for this release )

@mbartlett21

This comment has been minimized.

Copy link
Owner

mbartlett21 commented Dec 12, 2018

I have created a version 1.0.0 in Onshape

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

Done

@emagdalenaC2i

This comment has been minimized.

Copy link
Collaborator Author

emagdalenaC2i commented Dec 12, 2018

So, @mbartlett21 we should close this issue, rigth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.