Bugfix: LPC1768 IAP could not copy flash to flash #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This fixes an issue reported on the forums here: https://forums.mbed.com/t/limitation-of-flash-iap-for-lpc176x-flashing-from-ram-only/19892
The LPC1768's FlashIAP implementation could not successfully copy flash data to flash. Now, I adapted the existing RAM buffer scheme in the driver to fix this issue. I also did a general cleanup of the lpc1768 flash code, including replacing the magic 1024 number with the page size, and fixing the reported deadlock issue if an operation fails (missed core_util_critical_section_exit() calls).
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
See comment below