Skip to content

mpsqa.arch: General improvements + support for disallowed dependencies #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexanderpann merged 15 commits into from
Sep 24, 2024
Merged

mpsqa.arch: General improvements + support for disallowed dependencies #204

alexanderpann merged 15 commits into from
Sep 24, 2024

Conversation

@alexanderpann
Copy link
Contributor

@alexanderpann alexanderpann commented Sep 20, 2024 •
edited
Loading

I called those disallowed dependencies "decouplings". Not sure if this is the right term. I had a hard time with the used terms in this language anyway. Please tell me if I replaced an official term somewhere.

@danielratiu
Copy link
Member

danielratiu commented Sep 24, 2024

I am playing around and I got over the following exceptions (TBH I am not sure how to fix them at best, this is why I am logging them here - I could add some null-guards but I am not sure if there is a better fix of the cause and not only the sympthom):

java.lang.NullPointerException: Cannot invoke "org.jetbrains.mps.openapi.model.SModel.getModule()" because the return value of "org.jetbrains.mps.openapi.model.SModelReference.resolve(org.jetbrains.mps.openapi.module.SRepository)" is null
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.formatLocation_id4XPt_HauH1N(ResultEntry__BehaviorDescriptor.java:78)
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.invokeSpecial0(ResultEntry__BehaviorDescriptor.java:142)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeSpecial(BaseBHDescriptor.java:350)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtualCommon(BaseBHDescriptor.java:298)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtual(BaseBHDescriptor.java:274)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invoke(BaseBHDescriptor.java:235)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke0(SMethodImpl.java:153)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke(SMethodImpl.java:128)
at org.mpsqa.lint.generic.editor.ResultEntry_EditorBuilder_a$4.getText(ResultEntry_EditorBuilder_a.java:191)
at jetbrains.mps.nodeEditor.cells.EditorCell_Property.synchronizeViewWithModel_internal(EditorCell_Property.java:80)
at jetbrains.mps.nodeEditor.cells.EditorCell_Property.(EditorCell_Property.java:49)
at jetbrains.mps.nodeEditor.cells.EditorCell_Property.create(EditorCell_Property.java:60)
at org.mpsqa.lint.generic.editor.ResultEntry_EditorBuilder_a.createReadOnlyModelAccessor_3(ResultEntry_EditorBuilder_a.java:189)
at org.mpsqa.lint.generic.editor.ResultEntry_EditorBuilder_a.createCollection_3(ResultEntry_EditorBuilder_a.java:175)
at org.mpsqa.lint.generic.editor.ResultEntry_EditorBuilder_a.createCollection_0(ResultEntry_EditorBuilder_a.java:67)
at org.mpsqa.lint.generic.editor.ResultEntry_EditorBuilder_a.createCell(ResultEntry_EditorBuilder_a.java:57)
at org.mpsqa.lint.generic.editor.ResultEntry_Editor.createEditorCell(ResultEntry_Editor.java:12)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createCell(EditorCellFactoryImpl.java:136)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createEditorCell_internal(EditorCellFactoryImpl.java:102)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createEditorCell(EditorCellFactoryImpl.java:89)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCell_internal(EditorManager.java:386)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCellWithoutAttributes(EditorManager.java:260)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCell(EditorManager.java:272)
at jetbrains.mps.nodeEditor.updater.UpdateSessionImpl.lambda$updateChildNodeCell$2(UpdateSessionImpl.java:225)
at jetbrains.mps.nodeEditor.updater.UpdateSessionImpl.runWithExplicitEditorHints(UpdateSessionImpl.java:347)
at jetbrains.mps.nodeEditor.updater.UpdateSessionImpl.updateChildNodeCell(UpdateSessionImpl.java:225)
at jetbrains.mps.nodeEditor.updater.UpdateSessionImpl.updateChildNodeCell(UpdateSessionImpl.java:214)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a$violationsListHandler_rud5j2_b2a.createNodeCell(FoundViolationsEditor_ComponentBuilder_a.java:181)
at jetbrains.mps.nodeEditor.cellProviders.AbstractCellListHandler.createInnerCells(AbstractCellListHandler.java:185)
at jetbrains.mps.nodeEditor.cellProviders.AbstractCellListHandler.createCells(AbstractCellListHandler.java:167)
at jetbrains.mps.nodeEditor.cellProviders.AbstractCellListHandler.createCells(AbstractCellListHandler.java:150)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a.createRefNodeList_0(FoundViolationsEditor_ComponentBuilder_a.java:155)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a.createCollection_3(FoundViolationsEditor_ComponentBuilder_a.java:146)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a.createCollection_0(FoundViolationsEditor_ComponentBuilder_a.java:68)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a.createCell(FoundViolationsEditor_ComponentBuilder_a.java:57)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor.createEditorCell(FoundViolationsEditor.java:19)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createEditorComponentCell(EditorCellFactoryImpl.java:146)
at org.mpsqa.lint.generic.editor.ReuseCheckableScript_InspectorBuilder_a.createComponent_0(ReuseCheckableScript_InspectorBuilder_a.java:32)
at org.mpsqa.lint.generic.editor.ReuseCheckableScript_InspectorBuilder_a.createCell(ReuseCheckableScript_InspectorBuilder_a.java:28)
at org.mpsqa.lint.generic.editor.ReuseCheckableScript_Editor.createInspectedCell(ReuseCheckableScript_Editor.java:15)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createCell(EditorCellFactoryImpl.java:136)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createEditorCell_internal(EditorCellFactoryImpl.java:102)
at jetbrains.mps.nodeEditor.cells.EditorCellFactoryImpl.createEditorCell(EditorCellFactoryImpl.java:89)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCell_internal(EditorManager.java:386)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCellWithoutAttributes(EditorManager.java:260)
at jetbrains.mps.nodeEditor.EditorManager.createEditorCell(EditorManager.java:272)
at jetbrains.mps.nodeEditor.EditorManager.createRootCell(EditorManager.java:115)
at jetbrains.mps.nodeEditor.updater.UpdateSessionImpl.performUpdate(UpdateSessionImpl.java:171)
at jetbrains.mps.nodeEditor.updater.UpdaterImpl.lambda$updateRootCell$0(UpdaterImpl.java:133)
at jetbrains.mps.typechecking.backend.TypecheckingSessionHandler.computeWithSession(TypecheckingSessionHandler.java:61)
at jetbrains.mps.nodeEditor.updater.UpdaterImpl.updateRootCell(UpdaterImpl.java:133)
at jetbrains.mps.nodeEditor.updater.UpdaterImpl.doUpdate(UpdaterImpl.java:114)
at jetbrains.mps.nodeEditor.updater.UpdaterImpl.update(UpdaterImpl.java:90)
at jetbrains.mps.nodeEditor.EditorComponent.rebuildEditorContent(EditorComponent.java:2057)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a$2.lambda$actionPerformed$0(FoundViolationsEditor_ComponentBuilder_a.java:134)
at jetbrains.mps.smodel.ActionDispatcher.dispatch(ActionDispatcher.java:98)
at jetbrains.mps.smodel.ActionDispatcher.lambda$wrap$0(ActionDispatcher.java:135)
at jetbrains.mps.smodel.LockRunnable.run(LockRunnable.java:60)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:872)
at jetbrains.mps.smodel.WorkbenchModelAccess.runReadAction(WorkbenchModelAccess.java:84)
at jetbrains.mps.smodel.ModelAccessBase.runReadAction(ModelAccessBase.java:56)
at org.mpsqa.lint.generic.editor.FoundViolationsEditor_ComponentBuilder_a$2.actionPerformed(FoundViolationsEditor_ComponentBuilder_a.java:134)
at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313)
at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
at java.desktop/java.awt.Component.processMouseEvent(Component.java:6648)
at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3392)
at java.desktop/java.awt.Component.processEvent(Component.java:6413)
at java.desktop/java.awt.Container.processEvent(Container.java:2266)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5022)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4854)
at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4948)
at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4575)
at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4516)
at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2310)
at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2802)
at java.desktop/java.awt.Component.dispatchEvent(Component.java:4854)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:781)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:730)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:724)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:754)
at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:752)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:751)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:909)
at com.intellij.ide.IdeEventQueue.dispatchMouseEvent(IdeEventQueue.java:831)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:753)
at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$5(IdeEventQueue.java:437)
at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:787)
at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$6(IdeEventQueue.java:436)
at com.intellij.openapi.application.TransactionGuardImpl.performActivity(TransactionGuardImpl.java:113)
at com.intellij.ide.IdeEventQueue.performActivity(IdeEventQueue.java:615)
at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$7(IdeEventQueue.java:434)
at com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:838)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:480)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:207)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:128)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:117)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:105)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:92)

java.lang.NullPointerException: Cannot invoke "java.io.File.getPath()" because "file" is null
at java.desktop/java.awt.Desktop.open(Desktop.java:426)
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.openLocation_id4XPt_HaE_RC(ResultEntry__BehaviorDescriptor.java:118)
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.invokeSpecial0(ResultEntry__BehaviorDescriptor.java:153)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeSpecial(BaseBHDescriptor.java:350)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtualCommon(BaseBHDescriptor.java:298)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtual(BaseBHDescriptor.java:274)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invoke(BaseBHDescriptor.java:235)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke0(SMethodImpl.java:153)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke(SMethodImpl.java:128)
<<<

java.lang.NullPointerException: Cannot invoke "org.jetbrains.mps.openapi.model.SModel.getModelRoot()" because "model" is null
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.openLocation_id4XPt_HaE_RC(ResultEntry__BehaviorDescriptor.java:100)
at org.mpsqa.lint.generic.behavior.ResultEntry__BehaviorDescriptor.invokeSpecial0(ResultEntry__BehaviorDescriptor.java:151)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeSpecial(BaseBHDescriptor.java:350)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtualCommon(BaseBHDescriptor.java:298)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invokeNonVirtual(BaseBHDescriptor.java:274)
at jetbrains.mps.core.aspects.behaviour.BaseBHDescriptor.invoke(BaseBHDescriptor.java:235)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke0(SMethodImpl.java:153)
at jetbrains.mps.core.aspects.behaviour.SMethodImpl.invoke(SMethodImpl.java:128)
at org.mpsqa.lint.generic.editor.ResultLocationClick$1.execute_internal(ResultLocationClick.java:26)
at org.mpsqa.lint.generic.editor.ResultLocationClick$1.execute(ResultLocationClick.java:23)
at jetbrains.mps.nodeEditor.actions.CellActionExecuter.lambda$execute$1(CellActionExecuter.java:54)
at jetbrains.mps.editor.runtime.commands.EditorCommandAdapter.doExecute(EditorCommandAdapter.java:46)
at jetbrains.mps.editor.runtime.commands.EditorCommand.run(EditorCommand.java:55)
at jetbrains.mps.smodel.WorkbenchModelAccess$UndoContextSetup.run(WorkbenchModelAccess.java:367)
at jetbrains.mps.smodel.ActionDispatcher.dispatch(ActionDispatcher.java:98)
at jetbrains.mps.smodel.ActionDispatcher.lambda$wrap$0(ActionDispatcher.java:135)
at jetbrains.mps.smodel.ActionDispatcher.dispatch(ActionDispatcher.java:98)
at jetbrains.mps.smodel.ActionDispatcher.lambda$wrap$0(ActionDispatcher.java:135)
at jetbrains.mps.smodel.LockRunnable.run(LockRunnable.java:60)
at com.intellij.openapi.application.impl.ApplicationImpl.runWriteAction(ApplicationImpl.java:980)
at jetbrains.mps.smodel.TryRunPlatformWriteHelper.runWrite(TryRunPlatformWriteHelper.java:103)
at jetbrains.mps.smodel.TryRunPlatformWriteHelper.lambda$withPlatformWrite$1(TryRunPlatformWriteHelper.java:96)
at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:219)
at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:174)
at com.intellij.openapi.command.impl.CoreCommandProcessor.executeCommand(CoreCommandProcessor.java:164)
at jetbrains.mps.smodel.WorkbenchModelAccess.executeCommand(WorkbenchModelAccess.java:302)
at jetbrains.mps.smodel.ProjectModelAccess2.executeCommand(ProjectModelAccess2.java:35)
at jetbrains.mps.nodeEditor.actions.CellActionExecuter.lambda$execute$2(CellActionExecuter.java:57)
at jetbrains.mps.nodeEditor.EditorContext.lambda$runWithContextCell$2(EditorContext.java:254)
at jetbrains.mps.nodeEditor.EditorContext.runWithContextCell(EditorContext.java:265)
at jetbrains.mps.nodeEditor.EditorContext.runWithContextCell(EditorContext.java:253)
at jetbrains.mps.nodeEditor.actions.CellActionExecuter.execute(CellActionExecuter.java:53)
at jetbrains.mps.nodeEditor.actions.ActionHandlerImpl.executeAction(ActionHandlerImpl.java:41)
at jetbrains.mps.nodeEditor.selection.EditorCellSelection.executeAction(EditorCellSelection.java:169)
at jetbrains.mps.nodeEditor.selection.EditorCellLabelSelection.executeAction(EditorCellLabelSelection.java:171)
at jetbrains.mps.nodeEditor.EditorComponent$7.mouseClicked(EditorComponent.java:481)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
at java.desktop/java.awt.AWTEventMulticaster.mouseClicked(AWTEventMulticaster.java:277)
at java.desktop/java.awt.Component.processMouseEvent(Component.java:6651)
at java.desktop/javax.swing.JComponent.processMouseEvent(JComponent.java:3392)
at java.desktop/java.awt.Component.processEvent(Component.java:6413)
at java.desktop/java.awt.Container.processEvent(Container.java:2266)
at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5022)

<<<<<<<<

@alexanderpann alexanderpann force-pushed the bugfix/arch_language_improvements branch from 653fc11 to a44ec3c Compare September 24, 2024 11:08
@danielratiu
Merge remote-tracking branch 'origin/maintenance/MPS-2022.3' into bug…
ec0e30f 
…fix/arch_language_improvements

# Conflicts:
#	code/languages/org.mpsqa.build/solutions/org.mpsqa.build/models/org.mpsqa.build._080_lint_build.mps
@danielratiu danielratiu marked this pull request as ready for review September 24, 2024 13:58
@danielratiu danielratiu self-requested a review September 24, 2024 13:58
danielratiu
danielratiu approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@danielratiu danielratiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the cleanups!

@alexanderpann alexanderpann merged commit 3c2e37a into maintenance/MPS-2022.3 Sep 24, 2024
@alexanderpann alexanderpann deleted the bugfix/arch_language_improvements branch September 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielratiu danielratiu danielratiu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexanderpann @danielratiu