Adds linter that ensures all smodelAttributes are of concept Attribute #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielratiu
merged commit b5b99c0
into
mbeddr:maintenance/MPS-2023.2
1 of 2 checks passed
danielratiu
pushed a commit
that referenced
this pull request
Nov 7, 2024
* adds linter that enforces that virtual method is overriden (cherry picked from commit 3805c11) * fixes resolve info * adds linter that ensures all smodelAttributes are of concept Attribute. (#222) * updates logic of the linter * updates docstring * fixes resolve info * lint: cosmetic improvements of 'mandatory_virtual_method_override' --------- Co-authored-by: Vit Losenicky <vit.losenicky@porsche-engineering.cz> Co-authored-by: Vit Losenicky <87519379+vit-losenicky@users.noreply.github.com> Co-authored-by: Daniel Ratiu <ratiud@mail.google.com>
danielratiu
added a commit
that referenced
this pull request
Nov 8, 2024
* adds linter that enforces that virtual method is overriden (cherry picked from commit 3805c11) * fixes resolve info * adds linter that ensures all smodelAttributes are of concept Attribute. (#222) * updates logic of the linter * updates docstring * fixes resolve info * lint: cosmetic improvements of 'mandatory_virtual_method_override' * deprecated: enhanced the "DeprecatedNodesFinder" to search also for references to deprecated nodes (#227) * deprecated: enhanced the "DeprecatedNodesFinder" to search also for references to deprecated nodes * deprecated: File -> Force Save All * deprecated: fixed the case when a node references MORE deprecated nodes ... + remove the restriction to consider only a subset of deprecated results when too many deprecations are found --------- Co-authored-by: Daniel Ratiu <ratiud@mail.google.com> * arc: removed not needed dependencies (#229) Co-authored-by: Daniel Ratiu <ratiud@mail.google.com> --------- Co-authored-by: Vit Losenicky <vit.losenicky@porsche-engineering.cz> Co-authored-by: Vit Losenicky <87519379+vit-losenicky@users.noreply.github.com> Co-authored-by: Daniel Ratiu <ratiud@mail.google.com> Co-authored-by: danielratiu <ratiud@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.