Here are two minor bug fixes #1

Open
wants to merge 39 commits into
from

Projects

None yet

3 participants

@mta1309

These are two minor bug fixes in the preferences code. The IsEmpty method is currently unused but when I tried to use it (on a dead end that I since rejected) I discovered that it doesn't work.

The other change fixes things if you store preferences on certain WEBDAV servers. I'm switching to a2hosting.com for my hosting service and I discovered that their WEBDAV server doesn't require authentication for the initial OPTIONS request, and when it responds to the following GET request with a 401 failure it disconnects before Mulberry can do anything about it. I don't know if this is a Mulberry or a server problem (my guess is server), but getting authentication credentials before the OPTIONS request fixes it.

I suspect similar changes should be made to the other WEBDAV based modules but I don't have any easy way to test that.

I'm a novice at using github pull requests. Let me know if there is a problem with this one.

mta1309 and others added some commits Dec 13, 2011
@mta1309 mta1309 Fix up XCode projects a bit.
Change the location of the plug-ins in the Mulberry project to be based
on BUILT_PRODUCTS_DIR instead of instead of SOURCE_ROOT.  This makes
the project work regardless of the setting of the "Build Location"
XCode preference.  In order to make this work for both Debug and
Release builds of the main project, Release builds were added to each
plug-in project.  Some other changes were made by XCode 4 on its own.
0967787
@mta1309 mta1309 Change the build products location for plug-ins to ../../MacOS/build
This is needed to make the build work when the XCode "Build Location"
preference is set to "Location Specified by Targets".  More importantly
the command line tool ignores this preference and always acts as if it
is on.  As a beneficial side effect, all the build directories in the
Plug-ins directory disappear.
4d3ad28
@mta1309 mta1309 Changes to keep XCode from asking me to upgrade the projects. 1036bc5
@mta1309 mta1309 Turn off the XCode upgrade warnings in the PluginLibraries project. 836ced4
@mta1309 mta1309 Fix line endings. 652bc72
@mta1309 mta1309 Update CICalender with line ending changes 0c25440
@mta1309 mta1309 Update submodules. 12913f9
@mta1309 mta1309 The IsEmpty() method on CBlockOptionsMap is backwards.
It returns true only if the map is not empty.
f019b6e
@mta1309 mta1309 Get authentication credentials before the first WEBDAV transaction.
Mulberry handles the 401 authentication failure response and gets
credentials when necessary, but this doesn't work right with some
WEBDAV servers.  As a work around get credentials before the first
transaction.
c2a6fe2
@mta1309 mta1309 Sort some files alphabetically in the GUI aaeb79c
@mta1309 mta1309 The IsEmpty() method on CBlockOptionsMap is backwards.
It returns true only if the map is not empty.
7728013
@mta1309 mta1309 Get authentication credentials before the first WEBDAV transaction.
Mulberry handles the 401 authentication failure response and gets
credentials when necessary, but this doesn't work right with some
WEBDAV servers.  As a work around get credentials before the first
transaction.
3020244
@mta1309 mta1309 Merge branch 'master' into working 56a1b09
@mta1309 mta1309 add -Wno-logical-op-parentheses to plugins project to avoid a && B ||…
… c warnings.
f1ccaed
@mta1309 mta1309 Avoid warnings for unused return value from BIO_flush and BIO_reset 4e616f1
@SpareSimian SpareSimian Add Win32 VC10 project files. Ignore Win32 build output directories a…
…nd local project state.
3e4f1df
@SpareSimian SpareSimian Ignore Visual Studio local solution state and precompiled headers dir. f39d5c2
@SpareSimian SpareSimian Use newer Windows header for finding system directories. 41ec274
@SpareSimian SpareSimian Newer Windows compiler defines most errno constants now. a67da22
@SpareSimian SpareSimian back_inserter requires <iterator>. 2510dcf
@SpareSimian SpareSimian NULL as template parameter must be cast to real pointer type. 0ff157b
@SpareSimian SpareSimian Changes to use openssl-1.0. Netscape certificate import currently #if…
…0'd out.
cb337fc
@SpareSimian SpareSimian Move openssl-1.0.0d to vendor subdirectory in preparation for making …
…it a submodule. Add new files from upstream to VC10 project.
f3287bf
@SpareSimian SpareSimian High-bit ASCII requires a (char) cast. cf224e3
@SpareSimian SpareSimian Iterators invalidated by erase() were being used in CSearchCriteriaCo…
…ntainer::ConstructSearch().
406d7e5
@SpareSimian SpareSimian Fix initial Win32 window positioning for taskbar at left or top. eb3287a
@SpareSimian SpareSimian Remove old Win32 RectOnScreen implementation. 71029ed
cyrusdaboo Code clean-up 1d336b0
cyrusdaboo Make sure attendee state icon is shown properly. c6726d5
cyrusdaboo Separator widget not needed. 6a0f9bd
cyrusdaboo Minor fixes. (svn #456) 1140175
cyrusdaboo Improve the application and URL launching on OS X. (svn #457) 9d763e4
cyrusdaboo Calendar display name tweaks. (svn #458) 4fa5aef
cyrusdaboo Fixing some sync report issues. (svn #459) e46db23
cyrusdaboo Version/year bump. (svn #460) 443bcb5
@mbert Debian package version bump. 42e5285
@mta1309 mta1309 Merge branch 'XCode4' into working ca7eea0
@mta1309 mta1309 Merge branch 'master' into working 3f6438e
@mta1309 mta1309 New versions of XMLlib and CICalendar fa6d96c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment