Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark figures #15

Closed
mbhall88 opened this issue Oct 11, 2022 · 7 comments
Closed

Benchmark figures #15

mbhall88 opened this issue Oct 11, 2022 · 7 comments
Labels
paper Issues related to the analysis for the paper

Comments

@mbhall88
Copy link
Owner

Create benchmark figures for time and memory usage.

How do we want to do time? CPU time, wall time? I guess this gets complicated by threads, although I am using 2 for each tool at the moment.

@mbhall88 mbhall88 added the paper Issues related to the analysis for the paper label Oct 11, 2022
@mbhall88
Copy link
Owner Author

Okay, so this is what I have for the nanopore data. Anything we want changed?

Runtime

image

Max. RAM usage

image

@lachlancoin
Copy link
Collaborator

lachlancoin commented Oct 12, 2022 via email

@iqbal-lab
Copy link
Collaborator

Looks great. Nothing to change, though I'm wondering what the p values are testing

@lachlancoin
Copy link
Collaborator

lachlancoin commented Oct 12, 2022 via email

@mbhall88
Copy link
Owner Author

mbhall88 commented Oct 12, 2022

I used a wilcoxon signed-rank test. Basically the nonparametric version of a paired t-test (because I'm lazy and couldn't be bothered testing for normality 😅 )

Pretty clear they are not from the plot but I guess it helps if you want to say "significantly different"

It wasn't actually clear to me that the runtimes would be significantly different for drprg and mykrobe

@mbhall88
Copy link
Owner Author

Here are the Illumina figures. These aren't final as this is only a subset of 400 samples, but I can't imagine it will change dramatically.

Memory

image

Runtime

image

@mbhall88
Copy link
Owner Author

mbhall88 commented Nov 7, 2022

The latest figures after adding in the racon denovo from iqbal-lab-org/pandora#299 can be seen in iqbal-lab-org/pandora#303 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper Issues related to the analysis for the paper
Projects
None yet
Development

No branches or pull requests

3 participants