Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back to lazy mutation #1145

Merged
merged 1 commit into from Dec 8, 2020
Merged

Change back to lazy mutation #1145

merged 1 commit into from Dec 8, 2020

Conversation

mbj
Copy link
Owner

@mbj mbj commented Dec 8, 2020

  • It turns out that the original reason for the change to AOT
    mutation details is not valid anymore after the MRI bug that causes
    the VM to get stuck was reproduced outside memoizable sharing.

@source = Unparser.unparse(node)
@code = sha1[CODE_RANGE]
@identification = "#{self.class::SYMBOL}:#{subject.identification}:#{code}"
@monkeypatch = Unparser.unparse(subject.context.root(node))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work used to block the main thread. But its specific to an individual mutation. Moving unique to a mutation work into the killforks is key to improve concurrency.

* It turns out that the original reason for the change to AOT
  mutation details is not valid anymore after the MRI bug that causes
  the VM to get stuck was reproduced outside memoizable sharing.
@mbj mbj force-pushed the change/back-to-lazy-mutation branch from 11dad4d to 8bd300e Compare December 8, 2020 19:57
@mbj mbj merged commit 02be06f into master Dec 8, 2020
@mbj mbj deleted the change/back-to-lazy-mutation branch December 8, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant