Fix config attribute primitivity #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I HATE DYNLANGS!
* Reduces the amount of complex objects being referenced from Mutant::Config * Prepares to read the config from other sources than the CLI, (AKA config file) * Opens the door for configuring more details, Mutant::Config is supposed to be the source of "primitive truth", where Mutant::Env is the compiled version that applied the config to the env. * Fix adjacent mutations in Mutant::Env namespace
mbj
force-pushed
the
fix/config-attribute-primitivity
branch
from
4bf8034
to
a113393
Compare
mbj
force-pushed
the
fix/config-attribute-primitivity
branch
5 times, most recently
from
3c9846d
to
071dd49
Compare
* New primary interface #call makes specs and implementations much easier * We had #each mostly for historical reasons that are not relevant anymore * Mutation covers the Mutant::Matcher namespace
mbj
force-pushed
the
fix/config-attribute-primitivity
branch
from
071dd49
to
0fdd0c6
Compare
* A relict from the days where test selection depended on this information * Kill mutations in Mutation#insert, also very old code.
* Passing the expression parser directly reduces the amount of state integrations needlessly have access to.
mbj
force-pushed
the
fix/config-attribute-primitivity
branch
from
c91370d
to
a902123
Compare
mbj
force-pushed
the
fix/config-attribute-primitivity
branch
from
c7ce3cb
to
92e56de
Compare
|
Will not be finished in this repo. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config attributes should only be primitives, or nested primitives.
Before this changeset they could reference objects that in longterm need to be configurable / parsable from a config file.
So this changeset aims to reduce the "non primitive infection" of the config object to a minimum.