Markus Schirp
mbj

Organizations

@datamapper @bloomcrush
Aug 24, 2016
@mbj
  • @mbj 1f35049
    Remove redundant parent touching from order graph
Aug 24, 2016
@mbj
  • @mbj bef3607
    Remove redundant parent touching from order graph
Aug 24, 2016
mbj opened pull request MountainRoseHerbs/spree#481
@mbj
Remove redundant parent touching from order graph
1 commit with 3 additions and 3 deletions
mbj deleted branch fix/restart-checkout-on-session-create at MountainRoseHerbs/spree_auth_devise
Aug 25, 2016
Aug 24, 2016
@mbj
Aug 24, 2016
@mbj
Fix login to restart the order checkout flow
1 commit with 14 additions and 6 deletions
Aug 25, 2016
@mbj
Aug 25, 2016
mbj commented on pull request MountainRoseHerbs/spree#480
@mbj

If there is no selected shipping rate, shouldn't the cost be reset to 0? I was just thinking about the scenario where may there was a previously s…

Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#480
@mbj

Thinking about this more, could this be the root cause of the stale shipping amount? No, because the order updater later sets the shipment total …

Aug 24, 2016
@mbj
  • @mbj 1301093
    Remove use of update_columns
Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#480
@mbj

true, good catch.

Aug 24, 2016
@mbj
Aug 24, 2016
@mbj
Aug 24, 2016
@mbj
  • @mbj c3051dd
    Remove use of update_columns
Aug 24, 2016
@mbj
  • @mbj c02509f
    Remove use of update_columns
Aug 24, 2016
mbj opened pull request MountainRoseHerbs/spree#480
@mbj
Remove use of update_columns
1 commit with 14 additions and 24 deletions
Aug 24, 2016
Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#479
@mbj

Definitively, but not this PR.

Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#479
@mbj

It needs to be mass assigned from the ItemAdjustments, but in the long run its likely a good idea. Nothing I'd do in this PR.

Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#479
@mbj

@dkubb This is ready for review.

Aug 24, 2016
mbj commented on pull request MountainRoseHerbs/spree#479
@mbj

Just setting an arbitrary adjustment_total without creating any adjustment is invalid state. The code before silently cleaned up that invalid state…

Aug 24, 2016
@mbj fix/remove-adjustment-callbacks is now 5388956
Aug 24, 2016
@mbj
  • @mbj 557fae9
    Remove use of update_columns
Aug 24, 2016
@mbj
  • @mbj 8b8dd53
    Remove use of update_columns
Aug 24, 2016
@mbj
  • @mbj d36115b
    Remove use of update_columns
Aug 24, 2016
@mbj
  • @mbj e88e1c8
    Remove use of update_columns
Aug 24, 2016
@mbj
  • @mbj 5388956
    Remove adjustment callbacks from Spree::LineItem
Aug 24, 2016
@mbj
  • @mbj c20aca5
    Remove adjustment callbacks from Spree::LineItem
Aug 24, 2016
@mbj
  • @mbj 383b4fc
    Remove adjustment callbacks from Spree::LineItem