Markus Schirp mbj

Organizations

@datamapper @bloomcrush
@mbj
  • @mbj d032546
    Fix style to account for tooling updates
@mbj
  • @mbj 339ce57
    Fix style to account for tooling updates
@mbj
  • @mbj db721a8
    Fix style to account for tooling updates
mbj opened pull request mbj/morpher#22
@mbj
Fix stlye to account for tooling updates
1 commit with 97 additions and 39 deletions
mbj commented on pull request dkubb/dockerfiles#3
@mbj

@dkubb I finished a first code only pass. I'll do a validation task later when I'm more awake. There is one thing I noticed: This PR is not rails d…

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Is this "feature branch" still needed? AFAIK MSIE6 is extinct enough to ignore it.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

TIL: There is no long option for -c.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Lets use the long flag --recursive here for consistency.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Can we replace this in-place Procfile parser with a small ruby script like: exec ruby --require yaml -e "exec YAML.load_file('Procfile').fetch('web…

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Can these settings be done before nix is sourced?

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Can these settings be done before nix is sourced?

mbj commented on pull request dkubb/dockerfiles#3
@mbj

We IMO want to see probe requests. All of them. To make sure we do not loose important information on logsurfing.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

IMO in case we defaultto HTTPS we should ad the HSTS header here.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I think that this is a to broad matcher. The available OPTIONS should AFAIK be determined per URL and not generic. When we see an OPTIONS HTTP verb…

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I wounder if we should use the "flag terminating" pattern -- also for all the commands below.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

What is the best way to check these "C implemnented dependencies" are upto date? I assume that nix imposes some restrictions in the versions we can…

mbj commented on pull request dkubb/dockerfiles#3
@mbj

The current release of bundler is bundler-1.10.6, I guess we should upgrade the reference.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I think we want to include ruby-2.2.3p173 here.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I wounder if that is the right default. The generic app might be better of in shipping a self signed certificate and only expose 443/https.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

We discussed this in channel. Per app overlays to this file can fix it to a sane value.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Same for all other access_log off settings.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I think that this is a bad setting. We cannot declare a particular URL as "save and we never need insights into its access pattern". Potentially th…

mbj commented on pull request dkubb/dockerfiles#3
@mbj

Same here. Its from our commercial project, and will probably not apply to the majority of projects.

mbj commented on pull request dkubb/dockerfiles#3
@mbj

I think that this setting is to project specific, and might be better left out.

@mbj
  • @mbj 9724cb9
    Fix behavior of Store.default to raise on missing default
@mbj
mbj commented on pull request MountainRoseHerbs/spree#86
@mbj

AFAIK in the "production" code this is the only place. We centralized all the code path that create new orders into that one I'm changing in this c…

mbj commented on pull request MountainRoseHerbs/spree#85
@mbj

@dkubb This one is not ready for review. #86 is.

mbj commented on pull request MountainRoseHerbs/spree#86
@mbj

@dkubb Assuming all green this is ready for review.