Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to fix STI relations #203

Closed
wants to merge 4 commits into from
Closed

Conversation

@jgarber
Copy link

@jgarber jgarber commented Nov 17, 2011

Fixes #116 (with specs to expose the bug).

jgarber added 2 commits Nov 17, 2011
Inherited Models and Matching Contexts both had identical "should not include the object itself in the list of related objects" specs. I understand what it was supposed to be covering in Matching Contexts: exclude_self in #matching_contexts_for. You can set exclude_self = "" in related.rb and the spec doesn't fail! I fixed the spec so it properly covers the self-exclusion from matching contexts.
@jgarber
Copy link
Author

@jgarber jgarber commented Nov 17, 2011

Hmm, it still didn't fix my problem. Hang tight while I investigate.

@jgarber
Copy link
Author

@jgarber jgarber commented Nov 18, 2011

I missed covering #find_related_tags and #find_matching_contexts (got distracted by #find_related_on_tags and #find_matching_for_contexts), but I got it now. Please pull. Thanks!

@artemk artemk closed this Dec 9, 2011
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants