tag cloud bug for max count resolved #289

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

it makes a devisionbyzero exception when all counts are zero

@azinazadi azinazadi tag cloud bug for max count resolved
it makes a devisionbyzero exception when all counts are zero
7505012
Collaborator

artemk commented Oct 10, 2012

@azinazadi any tests?

This is an obvious functionality. I wouldnt recommend to test such a basic stuff.

Collaborator

tilsammans commented Apr 10, 2013

@azinazadi thank you for your contribution. I do appreciate it.

However this pull request really does need a test and a comment explaining the change. I don't think the proposed solution will work. You are wrapping the results in an array with the number 1 and choosing the max. This is a big change from how it used to work.

Please push a revised pull request with specs and comments. If you want to discuss further, please do! I am going to close this pull request for now, since there is no way it can be merged in its current state.

tilsammans closed this Apr 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment