Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rails 4 fixes #316

Closed
wants to merge 10 commits into
from

Conversation

Projects
None yet

tvdeyen commented Jan 2, 2013

Made changes to support Rails 4.

Collaborator

artemk commented Jan 2, 2013

Looks like tests are not passing

tvdeyen commented Jan 2, 2013

Strange, they are passing for me.
Can you please tell me what tests are not passing?

Thanks

Thomas

Am 02.01.2013 um 23:19 schrieb Artem Kramarenko notifications@github.com:

Looks like tests are not passing


Reply to this email directly or view it on GitHub.

arthurnn commented Jan 8, 2013

@tvdeyen @artemk test for old version of ruby(1.9.3 - ) wont pass as rails supports 1.9.3 up. Also PG looks broke. probably some change in the adapter .

PotHix commented Mar 6, 2013

I'm trying Rails 4.0.0.beta1 and a lot of warnings came out, so I came here and saw that the pull request is already opened.
The tests for this pull request will be fixed anytime soon?

LongMan commented Mar 11, 2013

Switched to version of @tvdeyen — thank you!

radosch commented Mar 12, 2013

I made a new branch on my repo, all tests passing and deprecation warnings fixed.
https://github.com/radosch/acts-as-taggable-on/tree/rails4

I didn't figure out, how to make a pull request for a rails 4 branch, because it wont be backwards compatible to rails 3

Let me know, if you are interested in my code base

Collaborator

artemk commented Mar 22, 2013

@radosch Since rails 4 is still on beta, i don't see any sense to support it.

@artemk artemk closed this Mar 22, 2013

PotHix commented Mar 22, 2013

LOL. Why not to keep a branch prepared for the new version? This is the reason to have a "beta" version...

radosch commented Mar 22, 2013

honestly?! ^^ thats your opinion?

Am 22.03.2013 um 16:39 schrieb Artem Kramarenko notifications@github.com:

@radosch Since rails 4 is still on beta, i don't see any sense to support it.


Reply to this email directly or view it on GitHub.

Collaborator

artemk commented Mar 22, 2013

honestly, i am happy that you have so much free time to support and maintain all your gems for all versions of rails from 1.1.3 till 4.0beta, but i don't.

PotHix commented Mar 22, 2013

If you're trying to improve the code for the new version you're a jobless. LOL. 👍

tvdeyen commented Mar 22, 2013

And your conclusion is to close someone's PR that did the work for you? Sorry, I don't get it. Rails 4 is coming anyway. So why not let people help? Will you deprecate aato when rails 4 is released? I really don't understand you.

@artemk I'm working on an application with Rails 4 like many, many others. You have a good programmer who improved your OPEN SOURCE project and as a manager the least you could have done is opening a branch for everyone who are already starting to upgrade. Many other gems have already started doing this, e.g. devise. In my opinion, there is not one valid reason not to allow people from preparing, experiencing and learning on the upcoming release. Open the damn branch please. Thanks

Collaborator

artemk commented Mar 25, 2013

@mathieugagne LOL man. Ok i will do when will have some time 👍

Now we're talking :) Thanks

PotHix commented Mar 25, 2013

👍

👍

I'm also beginning to upgrade apps to Rails 4...

@tvdeyen thank you.

Thanks @tvdeyen, your branch saved lot of my time.

Am I wrong to say there's no Rails 4 branch yet?

radosch commented Apr 3, 2013

No there isnt take one of the forks

Cheers

Von meinem iPhone gesendet

Am 03.04.2013 um 21:20 schrieb Alessandro Mencarini notifications@github.com:

Am I wrong to say there's no Rails 4 branch yet?


Reply to this email directly or view it on GitHub.

Thanks @radosch I went with @tvdeyen fork with profit :)

Collaborator

tilsammans commented Apr 10, 2013

I've been added as a maintainer for this gem and I am happy to support Rails 4.

However this pull request has some issues for me, in that it contains a lot of changes unrelated to Rails 4, such as whitespace fixes. If you want me to merge those, please be so kind to open a new PR for them so I can merge them easily.

Also this gem must support Rails 3 and as such the changes must be backwards compatible. If you want to work on your fork that is completely fine. I intend to make this gem backwards compatible with Rails 4, but it won't happen overnight.

I am also trying to get access to rubygems so I can push out 2.4.0.beta based on current master. When things don't explode I propose to work on Rails 4 support in a branch that will become acts-as-taggable-on version 3.0.0. Everyone on board? Choo choo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment