#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting) #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikettsie
changed the title
|
@seuros I cleaned up things a little bit adding a rake rule (or optionally a configuration setting) and updated the README.md consistently. |
|
could you squash your commits ? |
|
Of course @seuros , commits squashed. |
|
There is 20 commits in this PR. |
|
@seuros i finally could squash the commits |
| shared_examples_for 'without unique index' do | ||
| prepend_before(:all) { AddMissingUniqueIndices.down } | ||
| prepend_before(:all) do |
There was a problem hiding this comment.
When I implemented the patch as a migration I added the new one there, but then, after changing perspective (as the migration was an "execute", not tracked in the schema) I removed both migration and its call in the tag_spec.rb. Thus that changed. But I can reset the previous line.
|
for some reason, i can't merge it. can you rebase ? |
|
@seuros master seems ok now :-) |
added migration and rake task added rake rule and a config parameter to force binary collation (MySql) Added test for binary string collation included migration in test added self to migration moved binary collation migration to 'without unique index' context moved binary collation parameter from migration to app configuration (typo) removed import (typo) missing Configuration class name force_binary_collation change can be set by MySql users only (typo) method name using_mysql? when force_binary_collation is false, strict_case_match is not touch force_binary_collation not used in context without_unique_index updated README and simplified rake test rake task calls Configuration function updated README Gemfile cleaned cleaned READEME.md Added test for binary string collation (typo) removed import (typo) method name using_mysql? when force_binary_collation is false, strict_case_match is not touch force_binary_collation not used in context without_unique_index Gemfile cleaned updated CHANGELOG added migration and rake task Add context constraint to find_related_* methods. Fixes mbleigh#628 version bump added rake rule and a config parameter to force binary collation (MySql) added rake rule and a config parameter to force binary collation (MySql) applied changes added migration and rake task
seuros
added a commit
that referenced
this pull request
Mar 1, 2015
#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting)
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
mbleigh#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.