Use sanitize instead of quote_value #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails master quote_value now only accepts 1 param and aliases sanitize. sanitize has existed for a while only accepting 1 parameter and delegates to connection.quote just as quote_value did so this should preserve current behaviour (column name was never provided, only nil) and help future compatibility.
|
Issue addressed in d7ac3b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails master quote_value now only accepts 1 param and aliases
sanitize.
sanitize has existed for a while only accepting 1 parameter
and delegates to connection.quote just as quote_value did so this should
preserve current behaviour (column name was never provided, only nil)
and help future compatibility.