New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable table names #910

Merged
merged 8 commits into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@mizukami234
Contributor

mizukami234 commented Jul 23, 2018

background & why

I'm working on a Rails project which has own tags table.
In order to implement a new feature in my project, I need a new, independent tagging system, which AATO is suitable for. But I couldn't install it because duplicate table exists. So I forked this gem to make table names customizable.

implementation

you can simply specify in config:

ActsAsTaggableOn.tags_table = 'aato_tags'
ActsAsTaggableOn.taggings_table = 'aato_taggings'

@seuros seuros self-requested a review Jul 28, 2018

@seuros

Can you update the readme and the changelog ?

@mizukami234

This comment has been minimized.

Show comment
Hide comment
@mizukami234

mizukami234 Aug 3, 2018

Contributor

@seuros
I updated readme and changelog.
Thank you for reviewing.

Contributor

mizukami234 commented Aug 3, 2018

@seuros
I updated readme and changelog.
Thank you for reviewing.

@seuros

This comment has been minimized.

Show comment
Hide comment
@seuros

seuros Aug 7, 2018

Collaborator

@mizukami234 do you mind squashing the commits ? The first commits are not linked to your account.

Collaborator

seuros commented Aug 7, 2018

@mizukami234 do you mind squashing the commits ? The first commits are not linked to your account.

@mizukami234

This comment has been minimized.

Show comment
Hide comment
@mizukami234

mizukami234 Aug 8, 2018

Contributor

@seuros
The first commits are actually not mine, added by @junmoka . They're not linked to him, but he said he didn't mind that.

Contributor

mizukami234 commented Aug 8, 2018

@seuros
The first commits are actually not mine, added by @junmoka . They're not linked to him, but he said he didn't mind that.

@seuros seuros merged commit 6932226 into mbleigh:master Aug 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment