Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to move group to window in a different profile #645

Open
yuuyins opened this issue Jun 1, 2022 · 8 comments
Open

unable to move group to window in a different profile #645

yuuyins opened this issue Jun 1, 2022 · 8 comments

Comments

@yuuyins
Copy link

yuuyins commented Jun 1, 2022

Steps to reproduce

  1. Have two windows W1 and W2 in different profiles P1 and P2, respectively
  2. Open 2 tabs in W1
  3. Create a group for the 2 tabs in W1
  4. Try moving group from W1 to W2

Expected behavior

Move group from window W1 in Firefox profile P1 to another window W2 in profile P2 works.

Actual behavior

Move group from window W1 in Firefox profile P1 to another window W2 in profile P2 won't work. It just search the string moz-extension://f291fbf7-d05b-4e2d-a381-1db76a43e501/group/group.html#NixOS%20-%20NixOS%20Linux:id:JI4cLVpO9WOH in the search engine in a new tab in W2

Debug info

Addon data

P1

{ "settings": { "version": "4.10.1", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": true, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "m", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "auto", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": false, "tabHide": false, "actualAllUrls": false, "actualTabHide": false }, "storage": { "size": "123.2 kb", "props": { "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "3.3 kb", "favicons": "111.2 kb", "panelIndex": "1 b", "panels_v4": "1.4 kb", "prevTabsData_v4": "253 b", "profileID": "14 b", "settings": "2.8 kb", "tabsData_v4": "4 kb" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-private", "name": 7, "icon": "...", "cookieStoreId": "firefox-private", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "_XFeO1M9evje", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "Rcw-AwARxwje", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "92gYWzKwksWf", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "containers": [], "cssVars": "TypeError: can't convert undefined to object", "windows": [ { "state": "normal", "incognito": false, "tabsCount": 32 } ], "bookmarks": { "bookmarksCount": 51, "foldersCount": 24, "separatorsCount": 0, "maxDepth": 5 } }

P2

{ "settings": { "version": "4.10.1", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": true, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "session", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "m", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "auto", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": false, "tabHide": false, "actualAllUrls": false, "actualTabHide": false }, "storage": { "size": "184.8 kb", "props": { "cssVars": "1.6 kb", "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "1.2 kb", "favicons": "152.2 kb", "panelIndex": "1 b", "panels_v4": "775 b", "prevTabsData_v4": "13.1 kb", "profileID": "14 b", "settings": "2.8 kb", "tabsData_v4": "12.7 kb" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "fXt6mgqHglhe", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "containers": [], "cssVars": { "bg": "#FDF6E3" }, "windows": [ { "state": "normal", "incognito": false, "tabsCount": 112 } ], "bookmarks": { "bookmarksCount": 195, "foldersCount": 62, "separatorsCount": 68, "maxDepth": 6 } }

Logs

no log and the help page hasn't this log option

@dexeonify
Copy link

I'm unsure if there is an easy way to fix this. The thing is, the extensions IDs are different for every installation. You can even try reinstalling Sidebery in your current profile and you will realize that groups stop working.

@mbnuqw
Copy link
Owner

mbnuqw commented Jun 13, 2022

After abd0078 it will be possible to drag and drop sidebery items (tabs/bookmarks) between sidebery sidebars of different FF profiles, but only in "copy" mode, which means the source items will not be removed.

@yuuyins
Copy link
Author

yuuyins commented Jun 14, 2022

@mbnuqw i don't have an easy way to build node projects right now but i'll test it when I can. thank you very much!!

@mbnuqw
Copy link
Owner

mbnuqw commented Jun 14, 2022

@yuuyins, I'm planning to release a new version today, so just wait for v5.0.0b22

@yuuyins
Copy link
Author

yuuyins commented Jun 15, 2022

Just tested a bit.

On my normal profile, I upgraded from 4.10.1 to https://github.com/mbnuqw/sidebery/releases/tag/v5.0.0b22. But most group tabs didn't restore properly, which seems related to #656

Now on moving group tabs. With default configurations, it didn't work: when I tried moving a group to a window in another profile, it would just move it to a new window in the current profile. BUT changing the drag and drop settings page.setup/setup.html#settings_dnd from Open in new window to Pass dragged data to the target made it work as expected.

Thank you! You can close this issue as you wish.

@dexeonify
Copy link

Yes, the default configuration for Drag-and-drop is to open in new window (f996c99). If you only want to move tabs between sidebars, you should use the Alt key (or change the default setting).

Though for some reason, in a new profile, DND seems to do both actions at once.

@silverhook
Copy link

Is this only about drag-and-dropping from one profile to another or also about sending through e.g. a right-click menu?

For specific KDE-related workflow reasons I heavily rely on several Profiles too.

Tree-Style Tabs addresses this through syncing/sending the tabs via Firefox Sync, which can be a bit slow (and has some other quirks). If Sidebery were to fix this in a simpler way, that would be a great boon to my workflow :)

@mbnuqw
Copy link
Owner

mbnuqw commented Sep 28, 2022

@silverhook, this issue only for drag and drop. For sending tabs subscribe on #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants