New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n drop box style dragging feature #305

Closed
wants to merge 21 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@mcordell

mcordell commented Jun 30, 2014

This pull request adds a new drag and drop style to jqtree, my collaborator (@kennykaye) and I refer to this as box style dragging. We think this change makes jqtree even more versatile and adds support for a dragging style that is popular elsewhere ( e.g. this angular plugin).

I have created an example page which shows this feature in action, I wasn't quite sure how to build the tmpl files so I just did it manually.

I tried to extend the existing code and keep this new handler style confined to a single coffescript file. I had to slightly modify the existing drag and drop class.

gif-2

@coveralls

This comment has been minimized.

coveralls commented Jun 30, 2014

Coverage Status

Coverage decreased (-15.31%) when pulling 60a6688 on mcordell:drag-n-drop-box into 3476954 on mbraak:master.

@mbraak

This comment has been minimized.

Owner

mbraak commented Jul 1, 2014

Thanks a lot! I will have a look at it.

@mbraak

This comment has been minimized.

Owner

mbraak commented Jul 3, 2014

Hello Michael and Kenny,

Thanks a lot for the pull request. I think the drag-and-drop style and the box styling is very cool.

Unfortunately I don't want too include this pull request. I do like the 'boxed' drag-and-drop, but I think it's not good that you have to use it in combination with the 'box' styling. That makes it too much a special use case.

Would the 'boxed' drag-and-drop without the 'box' styling be a useful feature for you?

Greetings,
Marco

@mcordell

This comment has been minimized.

mcordell commented Jul 3, 2014

Hi Marco,
Yes, the JS portion of 'boxed' drag n drop is what we are primarily concerned with and the feature we are pull requesting. The accompanying styling is just for demonstration purposes and the examples, I would expect end-users to re-style the jqtree elements to their own preference. Please let me (us) know what else we can do to get the PR more in line.

Thanks,
Michael

@mbraak

This comment has been minimized.

Owner

mbraak commented Jul 4, 2014

I'm currently refactoring the code from your pull-request. It's in the box-dnd branch.

@kernicPanel

This comment has been minimized.

kernicPanel commented Jul 9, 2015

Is it still planned to be merged ?
I think this would be a great UX improvement.

@mbraak

This comment has been minimized.

Owner

mbraak commented Jul 9, 2015

This is not planned to be merged. It turned out to be too difficult to merge.

@mbraak mbraak closed this Nov 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment