Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new component called Start. #8

Merged
merged 2 commits into from
Oct 8, 2017

Conversation

PriyankaGitHub7
Copy link
Contributor

Adding a component Start with a simple textbox and button.

Adding a component Start with a simple textbox and button.
export class StartComponent implements OnInit {

constructor() { }
title = 'Simple Chat';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move that above the constructor

@@ -0,0 +1,9 @@
<div style= "text-align:center">
<h1>
Welcome to {{title}}!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can inline this h1 tag

@@ -0,0 +1,9 @@
<div style= "text-align:center">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the spaces before and after the equal sign.

</h1>
<form>
<input type = "text" name = "username" placeholder = "Enter your username" />
<button type = "submit">Start chatting!</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in line 1

Removed spaces and ordering of the statements.
@mbrandau mbrandau merged commit 8c0cf7f into mbrandau:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants