Skip to content

chore: various dependency updates#167

Merged
digitalcora merged 4 commits into
masterfrom
cfg-deps
Dec 14, 2020
Merged

chore: various dependency updates#167
digitalcora merged 4 commits into
masterfrom
cfg-deps

Conversation

@digitalcora

Copy link
Copy Markdown
Contributor

See commit messages for details!

The new Credo correctly pointed out that since we're using Elixir 1.10,
we should use `compile_env` instead of `get_env` with module attributes.
@digitalcora digitalcora requested review from a team and lemald and removed request for a team December 14, 2020 22:09
@digitalcora digitalcora changed the title various dependency updates chore: various dependency updates Dec 14, 2020
@codecov

codecov Bot commented Dec 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #167 (23e4898) into master (1443e8e) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   97.19%   97.10%   -0.10%     
==========================================
  Files          58       58              
  Lines        1035     1035              
==========================================
- Hits         1006     1005       -1     
- Misses         29       30       +1     
Impacted Files Coverage Δ
lib/concentrate/sink/s3.ex 100.00% <ø> (ø)
...ib/concentrate/producer/httpoison/state_machine.ex 99.23% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1443e8e...23e4898. Read the comment docs.

@lemald lemald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@digitalcora digitalcora merged commit c51fabf into master Dec 14, 2020
@digitalcora digitalcora deleted the cfg-deps branch December 14, 2020 22:25
paulswartz added a commit that referenced this pull request Dec 28, 2023
In particular, `AliasOrder` should have been the default before, but for
whatever reason in #167 it was set to `false`.
paulswartz added a commit that referenced this pull request Dec 28, 2023
In particular, `AliasOrder` should have been the default before, but for
whatever reason in #167 it was set to `false`.
paulswartz added a commit that referenced this pull request Jan 3, 2024
In particular, `AliasOrder` should have been the default before, but for
whatever reason in #167 it was set to `false`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants