fix(UpcomingDepartures): Show crossed out scheduled time for Delayed status#2934
Merged
joshlarson merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
thecristen
approved these changes
Feb 11, 2026
Collaborator
thecristen
left a comment
There was a problem hiding this comment.
The test titles and PR description helped explain to me why this change is desired. LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [SF/UD] 🐞 A status of "Delayed" should still show the crossed-out original time if scheduled and predicted times are more than a minute apart
Implementation
Screenshots
(Before on the left; After on the right)
How to test
This is tricky to test. You could try to use LiveBook or IEx to find a prediction with a
Delayedstatus:but
Delayed-status predictions happen somewhat infrequently, so you could be waiting for a while....or you can hack
Predictions.Repo.all/1to make all predictions have theDelayedstatus by tacking on 👇 to the end (please don't commit this!):(this is how I got the screenshots above - the 5:40 train is actually on time 😏)
Good luck!