Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overlay Button is gone #48

Open
jnlissy opened this Issue Jul 17, 2012 · 37 comments

Comments

Projects
None yet
@jnlissy
Copy link

jnlissy commented Jul 17, 2012

The Add Overlay button gone. I can't upload an overlay. Firefox 14.0.1

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 17, 2012

@markstewart

This comment has been minimized.

Copy link

markstewart commented Jul 17, 2012

I'm also having the same issue Firefox 14.0.1 pp version 1.7.1

@AlchemyCompSol

This comment has been minimized.

Copy link

AlchemyCompSol commented Jul 17, 2012

Yes, me too. It started on Sunday 7/15. I'm not entirely sure, but I think there was an update to Firebug a few days ago, and I wonder if that's the problem.....

@eawer

This comment has been minimized.

Copy link

eawer commented Jul 18, 2012

I have the same problem. Win 7/32, Firefox 13.0.1. Upgrade to 14.0.1 didn't solve the problem.

@kvigor

This comment has been minimized.

Copy link

kvigor commented Jul 18, 2012

WIN 7 (With and Without admin permissions)
FF 13.0.1

Have the same problem. Does JRE need to be installed?

@peter-gromov

This comment has been minimized.

Copy link

peter-gromov commented Jul 18, 2012

So do I, the button is gone at work (Win 7) and at home PC either (XP).
What a pity ((

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 18, 2012

solution!!

  1. open firebug
  2. click on the button - to open in a separate window
  3. close Firefox
  4. open Firefox
  5. open firebag
  6. "add overlay" button appear in the pixel perfect, but all the old layers will be lost and "add overlay" button will be lost when you expand firebug!!!!!
@jnlissy

This comment has been minimized.

Copy link
Author

jnlissy commented Jul 18, 2012

@daimonkor that gives me the button back, however, I can't click within the input to turn on the overlay. Do you have this problem as well?

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 18, 2012

what is that "I can't click within the input to turn on the overlay", please write more

my hack work for me and yes - I don`t add overlay after expand window firebug

http://prntscr.com/cb4ni
http://prntscr.com/cb4v4

@markstewart

This comment has been minimized.

Copy link

markstewart commented Jul 18, 2012

I found this fix in user Enyby's comment on issue #46. Worked for me in OS X.

Search for the file PixelPerfectPanel.js within your profile.

in the PixelPerfectPanel.js file add line:

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

after:

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref));
addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

Restart and the "Add Overlay" option should now appear in the drop down

@jnlissy

This comment has been minimized.

Copy link
Author

jnlissy commented Jul 18, 2012

@daimonkor the input box left of the overlay, cannot be clicked. There is a little box you click within to turn on and off layers. So my button is back, but I can't turn on layers.

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 18, 2012

yes, I see that and I reload page and overlay work

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 18, 2012

where is PixelPerfectPanel.js on Windows XP?

@markstewart

This comment has been minimized.

Copy link

markstewart commented Jul 18, 2012

@daimonkor It should be inside your FF profile directory at this path:

extensions\pixelperfectplugin@openhouseconcepts.com\chrome\pixelperfect\content\PixelPerfectPanel.js

To find your profile directory, in Firefox navigate to about:support and click on the button next to "Profile Folder".

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 18, 2012

Yes, its work, but need restart firefox for work additional overlay

@Kolombiken

This comment has been minimized.

Copy link

Kolombiken commented Jul 19, 2012

I have teh same issue.
Mac OS X Lion + Fx 14.0.1 + in Aurora as well.
Any chance of getting this fixed soon?

@thecodexpert

This comment has been minimized.

Copy link

thecodexpert commented Jul 19, 2012

@markstewart . It doesnt work on Windows 7 for me .. Add overlay button is still not showing even after adding

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

to PixelPerfectPanel.js

@mshoaibqureshi

This comment has been minimized.

Copy link

mshoaibqureshi commented Jul 20, 2012

Hey guys good work you doing...
well,

My System is Win 7 Home, FireFox 13.0.1
It was working for me until I tried to change the overlay with another one. I deleted the previous one and next, the Add Layer button had gone.!

I am having the same issue with no resolution at all.
I searched for the PixelPerfectPanel.js but I couldn't find it in my system.
Please tell where can I find it in my Win 7 Home.
the only folders I see in extensions folder of FF look liike '{9e4e-dsdd-sdsdd....}'

Is there any update coming here soon?

@mshoaibqureshi

This comment has been minimized.

Copy link

mshoaibqureshi commented Jul 20, 2012

ok so I actually found the PixelPerfectPanel.js in the following path..

'C:\Users\myuser\AppData\Roaming\Mozilla\Firefox\Profiles\8648houh.default\extensions\pixelperfectplugin@openhouseconcepts.com\chrome\pixelperfect\content'

I added the line

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

after

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref));
addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

And it actually worked.
I have now the add layer button in my dropdown,
BUT,
I still can't SHOW/HIDE the layer.

@daimonkor : please tell how to resolve that issue. mere restart didn't help

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 20, 2012

http://prntscr.com/ce06c , but where is button?))

First work overlay failed sometimes, need restart firefox.

@mshoaibqureshi

This comment has been minimized.

Copy link

mshoaibqureshi commented Jul 20, 2012

@daimonkor:
My issue is totally resolved!
after adding that code, it just needed a few restarts.

BUT one more thing,
I feel there still is some issue when it comes to tabbed overlays.
I mean in FF, If I want to open different overlays in different tabs, I simply CAN'T
Is there any feature coming like that??

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 20, 2012

Yes I see it too (wtf?)(((((
so need restart

@zzarazza

This comment has been minimized.

Copy link

zzarazza commented Jul 23, 2012

I've added the lines and refreshed a couple of times but it didn't work for me, no Add overlay in FF 14.0.1 on Lion.

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 23, 2012

Could you guys give me path where I can find file PixelPerfectPanel.js in Lion?

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 23, 2012

Oh, I figured it out now!
For those who's needed or confused.
Open Firefox. Type in address link "about:support".
in Application Basics > Profile Folder click "Show in Finder" button.
And find file there: extensions\pixelperfectplugin@openhouseconcepts.com\chrome\pixelperfect\content\PixelPerfectPanel.js

in the PixelPerfectPanel.js file find this peace of code:

addMenuOption('Hide Statusbar Icon', buildToggleBoolPrefFn(hideStatusBarPref), pixelPerfect.utils.getBoolPref(hideStatusBarPref));
addMenuOption('Hide Overlay When Inspecting', buildToggleBoolPrefFn(hideWhenFocusLostPref), pixelPerfect.utils.getBoolPref(hideWhenFocusLostPref));

after above lines and before "return menuOptions;" add the following:

addMenuOption('Add Overlay', Firebug.PixelPerfectModule.addOverlay, false);

Save. Restart Firefox.

In the Pixel Perfect menu (click "arrow") you will find "Add overlay" option.

@Kolombiken

This comment has been minimized.

Copy link

Kolombiken commented Jul 25, 2012

Ukando: Thank you! That actually works.
Can someone please do a real fix so we all don't need to hack the plugin?

@charlesmeyer

This comment has been minimized.

Copy link

charlesmeyer commented Jul 25, 2012

Please fix

@monkviper

This comment has been minimized.

Copy link

monkviper commented Jul 27, 2012

@markstewart : I have added the add overlay button. Thanks a lot!

@daimonkor

This comment has been minimized.

Copy link

daimonkor commented Jul 27, 2012

It is no button, it is context menu item((

@yolise

This comment has been minimized.

Copy link

yolise commented Aug 2, 2012

I'd like to see a fix for this - it's a great idea, but I'm not really inclined to jump through hoops to get it working...

@ughost

This comment has been minimized.

Copy link

ughost commented Aug 3, 2012

omg it works.. thx guys! :)

@AlanCW

This comment has been minimized.

Copy link

AlanCW commented Aug 10, 2012

As of August 2012, the problem persists with Firefox 14 (Linux). The solution described above works. Many thanks.

@fmquaglia

This comment has been minimized.

Copy link

fmquaglia commented Sep 3, 2012

Same issue with Firefox 15 on Linux (Ubuntu) and Firebug 1.10.3
Solution editing PixelPerfect.js on profile works.

Thanks!

@lgerndt

This comment has been minimized.

Copy link

lgerndt commented Feb 1, 2013

Thank you SO MUCH for this fix, I've been jonesing for this Plugin to work for about 6 months and I really needed it today, and now it works! Thanks again.

@spheatherm

This comment has been minimized.

Copy link

spheatherm commented Feb 6, 2013

Awesome! Thanks so much ukando!

@ghost

This comment has been minimized.

Copy link

ghost commented Feb 6, 2013

No problem, somebody here did that earlier, I just structured that info. Follow me on twiiter: @alexpivtorak ;)

@QuestionDevelopment

This comment has been minimized.

Copy link

QuestionDevelopment commented May 22, 2014

Line Fix seems to be added by default now. The button is placed in a horrible place however. Within firebug..click the litte down arrow on the Pixel Perfect Table (directly to the right of the tab title).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.