This repository has been archived by the owner. It is now read-only.

extra byte added to HEVC SPS with mkvmerge 11.0.0 #1958

Closed
sneaker2 opened this Issue Apr 23, 2017 · 5 comments

Comments

2 participants
@sneaker2

sneaker2 commented Apr 23, 2017

I noticed mkvmerge 11.0.0 adding an extra byte (80 at 4C) to the end of the SPS (in CodecPrivate). This byte doesn't exist in the raw stream coming from x265 and isn't written by mkvmerge 10.0.0. I don't understand enough to judge if this intended or a bug. Sample uploaded to ftp.

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Apr 23, 2017

Owner

Thanks. I'll look into it.

Owner

mbunkus commented Apr 23, 2017

Thanks. I'll look into it.

@sneaker2

This comment has been minimized.

Show comment
Hide comment
@sneaker2

sneaker2 Apr 23, 2017

I just noticed I accidetally created "mkvmerge11.mkv" using mkvtoolnix-32bit-10.0.0-build20170415-01476-15fb08c74 (pre). But the result with 11.0.0 final is the same so it might actually help in finding the change responsible quicker...

sneaker2 commented Apr 23, 2017

I just noticed I accidetally created "mkvmerge11.mkv" using mkvtoolnix-32bit-10.0.0-build20170415-01476-15fb08c74 (pre). But the result with 11.0.0 final is the same so it might actually help in finding the change responsible quicker...

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Apr 23, 2017

Owner

I'm already investigating this. Well, there have been a couple of bug fixes in the HEVC parser, especially how the SPS is handled, and either one of those bug fixes introduced or at least unmasked another bug.

I'll find & fix it :)

Owner

mbunkus commented Apr 23, 2017

I'm already investigating this. Well, there have been a couple of bug fixes in the HEVC parser, especially how the SPS is handled, and either one of those bug fixes introduced or at least unmasked another bug.

I'll find & fix it :)

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Apr 23, 2017

Owner

Ouch, this is one stupid mistake…

Owner

mbunkus commented Apr 23, 2017

Ouch, this is one stupid mistake…

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 13, 2017

Owner

For the record: this issue is what's causing the encoding settings to be lost as well. They're not really lost, but the data stored in front of them is invalid causing parsers to abort or to parse the data in a wrong way.

Owner

mbunkus commented May 13, 2017

For the record: this issue is what's causing the encoding settings to be lost as well. They're not really lost, but the data stored in front of them is invalid causing parsers to abort or to parse the data in a wrong way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.